iscsi transport support broken due to use of incorrect oslo_config choices support
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
High
|
Anish Bhatt |
Bug Description
This changeset https:/
forces iscsi_iface to be one out of ('be2iscsi', 'bnx2i', 'cxgb3i', 'cxgb4i', 'qla4xxx', 'ocs'), this is incorrect. This is confusing iscsi_transport, an open-iscsi parameter with iscsi_iface, which is the generated iface file actually needed for iscsi_iface support.
This also directly contradicts the explanation given right below the parameter, and breaks iface support unless you create an iface with the same name as the transport when the default naming scheme will always follow 'transport_
I had previously pushed another changeset meant to avoid the very same (https:/
Changed in nova: | |
assignee: | nobody → Anish Bhatt (anish7) |
status: | New → In Progress |
Changed in nova: | |
importance: | Undecided → High |
tags: | added: libvirt volumes |
Changed in nova: | |
milestone: | none → liberty-2 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | liberty-2 → 12.0.0 |
Reviewed: https:/ /review. openstack. org/193414 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=66b9c2ceaea 3decc117cfe7d32 6a92bf2bdd169b
Committed: https:/
Submitter: Jenkins
Branch: master
commit 66b9c2ceaea3dec c117cfe7d326a92 bf2bdd169b
Author: Anish Bhatt <email address hidden>
Date: Thu Jun 18 22:52:04 2015 -0700
libvirt : remove broken olso_config choices option
Changeset ed9f1b8b restricted the allowed options for iscsi_iface
to the allowed transports mentioned in the help text. iface &
transport are distinct entities for open-iscsi, and an iface is
generally a mix of transport plus an underlying interface, hence
this change was incorrect. This breaks transport support and is
generally incorrect, hence reverting
Closes- Bug:1466730 bb193004df44794 404b58ca692
Change-Id: I687fb9c95133db