setting hotcue_X_activate to 1 while paused makes deck unable to stop playback

[Be]

If a script sets hotcue_X_activate to 1 while a deck is paused, the deck will play from that hotcue but hitting play/pause will not stop the track. The only way to fix this is to restart Mixxx. This does not occur with hotcue_X_gotoandplay.

[Be (be.ing)]

Setting hotcue_X_activate to 0 solves the issue.

[Be (be.ing)]

Well, setting hotcue_X_activate to 0 makes the deck able to be paused again, but it has a side effect. When hotcue_X_activate is set to 1 by a script while the deck is paused, setting it to 0 jumps back to the hotcue and stops. The user may want to press play to let playback continue before letting go of the hotcue button. Strangely, this works if the hotcue button is pressed in the GUI then play is set to 1 by a controller or the keyboard. It also works if hotcue_X_activated is mapped to a MIDI signal with the MIDI Learning Wizard. It only does not work when a script sets hotcue_X_activate to 1.

[Daniel Schürmann (daschuer)]

@Be:
Do you have fun and time to adopt it yourselves?
Do you need help?

[Be (be.ing)]

Well, I guess it is about time for me to start learning C++ then.

[Be (be.ing)]

I figured out that play must be set to 0 while hotcue_X_activate is 1 to continue playback after hotcue_X_activate is set to 0. This behavior is counterintuitive for script writers, so I'll make a note of it on the wiki. So, this bug is not crucial for mapping my controller, but it is still a serious issue in the event that a script fails to set hotcue_X_activate to 0.

[Owen Williams (ywwg)]

Script bugs are hard to quantify. We can't necessarily prevent all bad behavior that a script might do.

[Daniel Schürmann (daschuer)]

The bug is fixed in the current 1.12 (tested in git 5609)

* set sets hotcue_X_activate 1 == press the hotcue 1 button and keep ti pressed
* set play -> latching play, the would keep playing if you release hotcue 1
* reset play = pause, track stops.

Now it works reasonable, but keeping the hotcue_X_activate 1 is a script bug and should not happen.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8104