[packaging][7.0] pep8==1.5.7 is required

Bug #1466572 reported by Dmitry Teselkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
Mikhail Ivanov

Bug Description

It seems that 'pep8==1.4.6' causes errors 'Checker' object has no attribute 'blank_before'.

For example, periodic-keystone-python27-pkg-mos70 failed:
-----
15:07:46 keystone.tests.unit.test_hacking_checks.TestCheckOsloNamespaceImports.test
15:07:46 --------------------------------------------------------------------------
15:07:46
15:07:46 Captured traceback:
15:07:46 ~~~~~~~~~~~~~~~~~~~
15:07:46 Traceback (most recent call last):
15:07:46 File "keystone/tests/unit/test_hacking_checks.py", line 132, in test
15:07:46 self.assert_has_errors(code, expected_errors=errors)
15:07:46 File "keystone/tests/unit/test_hacking_checks.py", line 52, in assert_has_errors
15:07:46 actual_errors = [e[:3] for e in self.run_check(code)]
15:07:46 File "/usr/lib/python2.7/dist-packages/mock.py", line 1210, in patched
15:07:46 return func(*args, **keywargs)
15:07:46 File "keystone/tests/unit/test_hacking_checks.py", line 47, in run_check
15:07:46 checker.check_all()
15:07:46 File "/usr/lib/python2.7/dist-packages/pep8.py", line 1393, in check_all
15:07:46 self.check_logical()
15:07:46 File "/usr/lib/python2.7/dist-packages/pep8.py", line 1327, in check_logical
15:07:46 for result in self.run_check(check, argument_names):
15:07:46 File "/usr/lib/python2.7/dist-packages/pep8.py", line 1256, in run_check
15:07:46 arguments.append(getattr(self, name))
15:07:46 AttributeError: 'Checker' object has no attribute 'blank_before'
------
Logs: http://logs.mosi.mirantis.net/periodic-pkg/periodic-keystone-python27-pkg-mos70/e0d7f6b

The same job succeeded several days before because python-hacking Ubuntu package, that also installs pep8 as a dependency, was not installed and the latest version (pep8==1.5.7) from PyPI was used.
Logs: http://logs.mosi.mirantis.net/periodic-pkg/periodic-keystone-python27-pkg-mos70/486f095

hacking==0.8.1 requires pep8==1.4.5
hacking==0.9.0 requires pep8==1.5.6
hacking==0.10.1 requires pep8==1.5.7

During test run that faild hacking==0.10.1 was installed from MOS repository:
-----
15:01:01 698: python-hacking 0.10.1-0u~u14.04+mos1 0 1050 http://172.18.160.74/osci/mos/7.0/cluster/base/trusty/ trusty/main amd64 Packages
-----

So it seems that pep8==1.5.7 is also required for MOS=7.0

Tags: mosi
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to fuel-infra/jeepyb-config (master)

Related fix proposed to branch: master
Change author: Mikhail Ivanov <email address hidden>
Review: https://review.fuel-infra.org/7958

Mikhail Ivanov (mivanov)
Changed in mos:
assignee: nobody → Mikhail Ivanov (mivanov)
status: New → In Progress
Changed in mos:
importance: Undecided → Medium
milestone: none → 7.0
Revision history for this message
Dmitry Teselkin (teselkin-d) wrote :

We also need that package in master https://bugs.launchpad.net/mos/+bug/1468658

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to fuel-infra/jeepyb-config (master)

Reviewed: https://review.fuel-infra.org/7958
Submitter: Andrey Nikitin <email address hidden>
Branch: master

Commit: a2657f315461b4f954e229646cb63c15c6d413e7
Author: Mikhail Ivanov <email address hidden>
Date: Thu Jun 25 09:36:02 2015

Add packages/trusty/pep8

* according to global requirements [0] version should be updated
  [0]https://github.com/openstack/requirements/blob/master/global-requirements.txt#L296

Change-Id: I028d2fa91e4f454bb787cc80b6901aea3ddf067b
Related-Bug:#1466572

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/pep8 (7.0)

Fix proposed to branch: 7.0
Change author: Mikhail Ivanov <email address hidden>
Review: https://review.fuel-infra.org/8474

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/pep8 (7.0)

Reviewed: https://review.fuel-infra.org/8474
Submitter: Artem Silenkov <email address hidden>
Branch: 7.0

Commit: b4060478e5b0e80e807760e759f3372e0bfc9887
Author: Mikhail Ivanov <email address hidden>
Date: Thu Jun 25 12:08:57 2015

Add pep8 package to our repository

Change-Id: I50ef98d2226d9f64abafabc51f9f57b77dc96aea
Closes-Bug:#1466572

Mikhail Ivanov (mivanov)
Changed in mos:
status: In Progress → Fix Committed
Changed in mos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.