python-novaclient

improve hypervisor-show print out list

Bug #1466435 reported by Ritesh Paiboina on 2015-06-18

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	python-novaclient	Fix Released	Wishlist	Ritesh Paiboina	python-novaclient 2.27.0 "2.27.0"

Bug Description

Current hypervisor show's a list , which does not looks good when we have more number of cpu info features

For example, like this

nova hypervisor-show Cloud58
+---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Property | Value |
+---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| cpu_info_arch | x86_64 |
| cpu_info_features | ["pge", "avx", "clflush", "sep", "syscall", "vme", "dtes64", "msr", "fsgsbase", "xsave", "vmx", "erms", "xtpr", "cmov", "smep", "ssse3", "est", "pat", "monitor", "smx", "pbe", "lm", "tsc", "nx", "fxsr", "tm", "sse4.1", "pae", "sse4.2", "pclmuldq", "acpi", "tsc-deadline", "mmx", "osxsave", "cx8", "mce", "de", "tm2", "ht", "pse", "lahf_lm", "popcnt", "mca", "apic", "sse", "f16c", "ds", "pni", "rdtscp", "aes", "sse2", "ss", "ds_cpl", "pcid", "fpu", "cx16", "pse36", "mtrr", "pdcm", "rdrand", "x2apic"] |
| cpu_info_model | SandyBridge |
| cpu_info_topology_cores | 4 |
| cpu_info_topology_sockets | 1 |
| cpu_info_topology_threads | 1 |
| cpu_info_vendor | Intel |
| current_workload | 0 |
| disk_available_least | 406 |
| free_disk_gb | 402 |
| free_ram_mb | 11244 |
| host_ip | 172.16.73.58 |
| hypervisor_hostname | Cloud58 |
| hypervisor_type | QEMU |
| hypervisor_version | 2000000 |
| id | 1 |
| local_gb | 442 |
| local_gb_used | 40 |
| memory_mb | 15852 |
| memory_mb_used | 4608 |
| running_vms | 1 |
| service_disabled_reason | - |
| service_host | Cloud58 |
| service_id | 5 |
| state | up |
| status | enabled |
| vcpus | 4 |
| vcpus_used | 2 |
+---------------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

This is a whishlist bug to improve its output as follows

Ritesh Paiboina (rsritesh) on 2015-06-18

Changed in python-novaclient:
importance:	Undecided → Wishlist
assignee:	nobody → Ritesh (rsritesh)

Revision history for this message

Ritesh Paiboina (rsritesh) wrote on 2015-06-18:

Current.JPG Edit (96.2 KiB, image/jpeg)

Please see the image file of command output .

Revision history for this message

Ritesh Paiboina (rsritesh) wrote on 2015-06-18:

aftercodechanges.JPG Edit (85.5 KiB, image/jpeg)

Please see the command output after making code changes

Changed in python-novaclient:
status:	New → In Progress

Ritesh Paiboina (rsritesh) on 2015-06-19

Changed in python-novaclient:
status:	In Progress → Fix Committed

Revision history for this message

melanie witt (melwitt) wrote on 2015-06-19:

Hi Ritesh, the status Fix Committed means the patch that closes this bug has merged into the code base. The patch:

https://review.openstack.org/#/c/193068/

is still under review. If it merges, this bug will be automatically updated by the infra bot.

And if we ever set Fix Committed manually, we should include a link to the merged patch that fixed the bug in a comment here.

Changed in python-novaclient:
status:	Fix Committed → In Progress

Revision history for this message

Ritesh Paiboina (rsritesh) wrote on 2015-06-25:

Thanks Melanie, I think I have misunderstood the terminology.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-07-24: Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/193068
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=a061470a8edf282ab24911c20e6e033c97541cc5
Submitter: Jenkins
Branch: master

commit a061470a8edf282ab24911c20e6e033c97541cc5
Author: rsritesh <email address hidden>
Date: Thu Jun 18 13:08:34 2015 +0200

Improve hypervisor-show print list

    Current hypervisor-show <hostname> command does not properly list
    when there is a long list of cpu info feature. The long list of
    cpu info feature has comma-separated values.
    Because of this user is not able to read the print out properly.

print_dict() has been changed to show a list with comma-separated
values properly.

Change-Id: Icc53439cecd3b5eee2340267a0447ce209d7b653
Closes-Bug: #1466435