tox -e genconfig fails

Bug #1466198 reported by Eric Harney
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Kazumasa Nomura

Bug Description

Option hpxp_storage_cli appears to be causing an issue.

master @ 8b581e0 Merge "Replace basestring with six.string_types"

$ tox -e genconfig
genconfig create: /mnt/ssd1/src/cinder/.tox/venv
genconfig installdeps: -r/mnt/ssd1/src/cinder/requirements.txt, -r/mnt/ssd1/src/cinder/test-requirements.txt
genconfig develop-inst: /mnt/ssd1/src/cinder
genconfig runtests: commands[0] | /mnt/ssd1/src/cinder/tools/config/generate_sample.sh -b . -p cinder -o etc/cinder
/mnt/ssd1/src/cinder/.tox/venv/lib/python2.7/site-packages/novaclient/v1_1/__init__.py:30: UserWarning: Module novaclient.v1_1 is deprecated (taken as a basis for novaclient.v2). The preferable way to get client class or object you can find in novaclient.client module.
  warnings.warn("Module novaclient.v1_1 is deprecated (taken as a basis for "
Traceback (most recent call last):
  File "/usr/lib64/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/mnt/ssd1/src/cinder/cinder/openstack/common/config/generator.py", line 307, in <module>
    main()
  File "/mnt/ssd1/src/cinder/cinder/openstack/common/config/generator.py", line 304, in main
    generate(sys.argv[1:])
  File "/mnt/ssd1/src/cinder/cinder/openstack/common/config/generator.py", line 132, in generate
    for group, opts in _list_opts(mod_obj):
  File "/mnt/ssd1/src/cinder/cinder/openstack/common/config/generator.py", line 196, in _list_opts
    ret.setdefault(_guess_groups(opt, obj), []).append(opt)
  File "/mnt/ssd1/src/cinder/cinder/openstack/common/config/generator.py", line 176, in _guess_groups
    % opt.name
RuntimeError: Unable to find group for option hpxp_storage_cli, maybe it's defined twice in the same group?
Can not generate etc/cinder/cinder.conf.sample
ERROR: InvocationError: '/mnt/ssd1/src/cinder/tools/config/generate_sample.sh -b . -p cinder -o etc/cinder'
__________________________________________________________________________________ summary __________________________________________________________________________________
ERROR: genconfig: commands failed

Eric Harney (eharney)
description: updated
Liyingjun (liyingjun)
Changed in cinder:
status: New → Confirmed
assignee: nobody → Liyingjun (liyingjun)
Changed in cinder:
status: Confirmed → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
milestone: none → liberty-2
assignee: Liyingjun (liyingjun) → Jay Bryant (jsbryant)
Changed in cinder:
importance: High → Critical
Revision history for this message
Jay Bryant (jsbryant) wrote :

I am taking this bug. Our config file generation has been broken for too long. I am working on this right now.

Revision history for this message
Jay Bryant (jsbryant) wrote :

The first problem is with the fact that the options were being registered outside of the file where they were defined. This doesn't work for the config generator. It doesn't know which group to put the options in.

Once I resolve that problem it hits another error that I have not yet narrowed. Could be a bug in the old config generator. Working to find a solution.

Revision history for this message
Jay Bryant (jsbryant) wrote :

Yeah, the problem is that the old config generator has not support for cfg.Opt.

Will see what I can do to deal with that problem.

Changed in cinder:
assignee: Jay Bryant (jsbryant) → Kazumasa Nomura (kazumasa-nomura-rx)
Changed in cinder:
assignee: Kazumasa Nomura (kazumasa-nomura-rx) → Jay Bryant (jsbryant)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Jay Bryant (<email address hidden>) on branch: master
Review: https://review.openstack.org/195715
Reason: Abandoning this change as the driver owners have posted their own approach to this problem: https://review.openstack.org/#/c/195619

Changed in cinder:
assignee: Jay Bryant (jsbryant) → Kazumasa Nomura (kazumasa-nomura-rx)
Changed in cinder:
assignee: Kazumasa Nomura (kazumasa-nomura-rx) → nobody
Changed in cinder:
assignee: nobody → Kazumasa Nomura (kazumasa-nomura-rx)
Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Li Yingjun (<email address hidden>) on branch: master
Review: https://review.openstack.org/192987
Reason: already fixed

Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.