nova does not report if volume size is lesser than image size in boot from volume

Bug #1465947 reported by PrashantUpadhyay
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
In Progress
Low
Xuanzhou Perry Dong

Bug Description

In boot from volume , nova does not check whether size of the volume is adequate for the image passed. it puts the VM in error state with no further information about the error.

Changed in nova:
status: New → In Progress
assignee: nobody → PrashantUpadhyay (prashant-upadhyay)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by PrashantUpadhyay (<email address hidden>) on branch: master
Review: https://review.openstack.org/192571
Reason: duplicate

Revision history for this message
PrashantUpadhyay (prashant-upadhyay) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by PrashantUpadhyay (<email address hidden>) on branch: master
Review: https://review.openstack.org/196451
Reason: by mistake tags file got checked in not required.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/193444
Reason: This patch has been stalled for quite a while, so I am going to abandon it to keep the code review queue sane. Please restore the change when it is ready for review.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/196465
Reason: This patch is very old and appears to not be active any more. I am therefore abandoning it to keep the nova review queue sane. Feel free to restore the change when you're actively working on it again.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/198804
Reason: This patch is very old and appears to not be active any more. I am therefore abandoning it to keep the nova review queue sane. Feel free to restore the change when you're actively working on it again.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/194523
Reason: This patch is very old and appears to not be active any more. I am therefore abandoning it to keep the nova review queue sane. Feel free to restore the change when you're actively working on it again.

Changed in nova:
assignee: PrashantUpadhyay (prashant-upadhyay) → nobody
status: In Progress → Confirmed
Revision history for this message
John Garbutt (johngarbutt) wrote :

So I think we could treat this API change as removing a 500 error, so doesn't need a microversion bump.

Now implementing this check does duplicate a cinder check, but it seems a valid test to add to give a better APai experience, and raise a 400 error early in the boot process, just like the check against root-go for local disks.

tags: added: low-hanging-fruit
Changed in nova:
status: Confirmed → Triaged
importance: Undecided → Low
tags: added: api
Changed in nova:
assignee: nobody → Sivasathurappan Radhakrishnan (siva-radhakrishnan)
Revision history for this message
Andrea Rosa (andrea-rosa-m) wrote :

@siva-radhakrishnan if you are working on this bug, please mark it as "In progress", thanks.

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/348317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/348317
Reason: This patch has been sitting unchanged for more than 12 weeks. I am therefore going to abandon it to keep the review queue sane. Please feel free to restore the change if you're still working on it.

Sihan Wang (wsihan)
Changed in nova:
assignee: Sivasathurappan Radhakrishnan (siva-radhakrishnan) → Sihan Wang (wsihan)
Sihan Wang (wsihan)
Changed in nova:
assignee: Sihan Wang (wsihan) → nobody
Changed in nova:
status: In Progress → Confirmed
Sean Dague (sdague)
Changed in nova:
assignee: nobody → Sihan Wang (wsihan)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/348317
Reason: This review is > 4 weeks without comment, and is not mergable in it's current state. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → Confirmed
assignee: Sihan Wang (wsihan) → nobody
Changed in nova:
assignee: nobody → Xuanzhou Perry Dong (oss-xzdong)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/519666

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Stephen Finucane (<email address hidden>) on branch: master
Review: https://review.opendev.org/519666

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.