AIO script password may be 0-length

[Hugh Saunders]

The bootstrap aio script generates a password with variable length. The length depends on the number of alpha-numeric characters that are read from the system's random number generator.

See: https://github.com/stackforge/os-ansible-deployment/blob/master/scripts/bootstrap-aio.sh#L22

The problem with this is a that in a bad case, a short of 0-length password may be generated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/192220

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/193628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/193628
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=0a2158372ba7ccbeee6b83111b7002160bb9adf1
Submitter: Jenkins
Branch: kilo

commit 0a2158372ba7ccbeee6b83111b7002160bb9adf1
Author: Hugh Saunders <email address hidden>
Date: Tue Jun 16 15:18:43 2015 +0100

    Generate consistent length passwords in AIO

    The bootstrap-aio.sh script generates a password by reading a set number
    of characters from urandom then removing those that aren't alphanumeric.
    The problem with this is that its possible for 0 characters to remain.

    This patch changes the order so that tr (translate) reads urandom
    directly and removes non alphanumeric characters then that output is
    truncated to the required length. This ensures the generated password is
    always the desired length.

    Change-Id: I03984ab891f88fe4b064f7f7fcb71edf48096493
    Closes-Bug: #1465684
    (cherry picked from commit b98422b9743c7536a82ad9f07f2e86ddddf831c5)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.