generic_service declares package incorrectly

[Mike Dorman]

puppet-nova's generic_service defined type declares a package with title $nova_title. It does a check to see if the package exists in the catalog already first, but based on the title $package_name.

This results in the possibility of duplicate package declaration, or more likely, a failure on the package dependency for the service resource declared by the generic_service instance.

Example:

The spicehtml5proxy class uses the generic_service type to manage that service:

  nova::generic_service { 'spicehtml5proxy':
    enabled => $enabled,
    manage_service => $manage_service,
    package_name => $::nova::params::spicehtml5proxy_package_name,
    service_name => $::nova::params::spicehtml5proxy_service_name,
    ensure_package => $ensure_package,
  }

For EL-based distros, package_name = 'openstack-nova-console' and inside the generic_service type, $nova_title = 'nova-spicehtml5proxy'

This results in the generic_service type checking for the existence of Package[openstack-nova-console], but then is defining Package[nova-spicehtml5proxy]

The openstack-nova-console package already exists in the catalog, so Package[nova-spicehtml5proxy] is never defined, breaking the dependency set on Service[nova-spicehtml5proxy]

I believe generic_service should define the Package with a title of $package_name, rather than $nova_title.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/192009