The calculated number of samples based on the delay time is wrong. The actual delay time is only half as long as expected, e.g. setValue(1.0) results in a delay of 500 ms intead of 1000 ms. I noticed this when I tried to implement a bpm-synchronized echo out loop effect for my controller.
EchoEffect::getDelaySamples(): delay_time * sampleRate is the number of sample frames for the delay, but not the total number of samples for a stereo signal. The correct number of samples assuming 2 (= stereo) channels is 2 * delay_time * sampleRate. The following check (delay_samples % 2 == 1) becomes obsolete.
The new SoundSource API explicitly distinguishes between channel-dependent samples and channel-independent (sample) frames. If the rest of the processing pipeline adopts this naming (and drops the implicit assumption of stereo channels) then hopefully we will see fewer of those errors in the future.
https:/