Horizon running in newer django, the fields is now not sorted correctly.

Bug #1465221 reported by Serhii Vasheka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Timur Sufiev
Kilo
Fix Released
Undecided
Unassigned

Bug Description

Create User form has wrong order of fields.

Correct order : "name", "email", "password", "confirm_password", "project", "role".

Current order : "password", "confirm_password", "name", "email", "project", "role".

this becomes the cause for integration test(test_create_delete_user) fail.

Traceback (most recent call last):
/opt/stack/new/horizon/openstack_dashboard/test/integration_tests/tests/test_user_create_delete.py", line 26, in test_create_delete_user
self.assertTrue(users_page.is_user_present(self.USER_NAME))
File"/opt/stack/new/horizon/.tox/py27integration/local/lib/python2.7/site-packages/unittest2/case.py", line 678, in assertTrue
raise self.failureException(msg)
AssertionError: False is not true

Can be seen both on latest devstack, or gate-horizon-dsvm-integration gate job.

Revision history for this message
Serhii Vasheka (svasheka) wrote :
description: updated
description: updated
description: updated
Matthias Runge (mrunge)
Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/191784

Changed in horizon:
assignee: nobody → Timur Sufiev (tsufiev-x)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/191784
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d2f9b6604cbfbf3dc5c0328e783e27b3ef1a4e37
Submitter: Jenkins
Branch: master

commit d2f9b6604cbfbf3dc5c0328e783e27b3ef1a4e37
Author: Timur Sufiev <email address hidden>
Date: Mon Jun 15 15:59:01 2015 +0300

    Fix Create User form's fields sorting for Django 1.7

    Starting from Django 1.7 self.fields.keyOrder no longer works for
    setting fields ordering, need to rearrange fields there by recreating
    underlying OrderedDict.

    Change-Id: If0f4c7014a7a68f2ff0d0f2cb06f7b1c2e28436b
    Closes-Bug: #1465221

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → High
milestone: none → liberty-1
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/200004

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/kilo)

Reviewed: https://review.openstack.org/200004
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=82f63a52ef4e2f4e37741d9927a14c73987ac79d
Submitter: Jenkins
Branch: stable/kilo

commit 82f63a52ef4e2f4e37741d9927a14c73987ac79d
Author: Timur Sufiev <email address hidden>
Date: Mon Jun 15 15:59:01 2015 +0300

    Fix Create User form's fields sorting for Django 1.7

    Starting from Django 1.7 self.fields.keyOrder no longer works for
    setting fields ordering, need to rearrange fields there by recreating
    underlying OrderedDict.

    Change-Id: If0f4c7014a7a68f2ff0d0f2cb06f7b1c2e28436b
    Closes-Bug: #1465221
    (cherry picked from commit d2f9b6604cbfbf3dc5c0328e783e27b3ef1a4e37)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.