iSCSI login fails silently

[Avishay Traeger]

When doing iSCSI login, there is no check to see if it succeeded or not. With multipath, all calls to _connect_to_iscsi_portal() can fail, and there is no check. Without multipath, a warning is printed and the code proceeds.

If the login failed, an exception should be thrown, and the code should not proceed to scan devices.

[Walt Boring (walter-boring)]

https://review.openstack.org/#/c/231740/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/231740
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=166820ad11c0b0a83a4f6b1466d59de9808421c9
Submitter: Jenkins
Branch: master

commit 166820ad11c0b0a83a4f6b1466d59de9808421c9
Author: Walter A. Boring IV <email address hidden>
Date: Tue Oct 6 15:15:35 2015 -0700

    Fix silent iSCSI login failures

    This patch fixes an issue where every iSCSI login attempt fails
    and the code doesn't raise an exception. It used to silently fail
    with nothing but a log warning.

    The iSCSI connector now checks to make sure that at least 1 of the
    N potential target portals login attempts is successful.

    Change-Id: Id248c3f1b12385c9d26150c6aa9dd504c01d0df8
    Closes-Bug: #1464988

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/os-brick 0.6.0 release.