inconsistency in my file internal xfer

[Kinnin Vo-Shay]

 I made a number of transactions and edits in various places in Homebank; one of these changes was the addition of "transaction-X", an internal transfer transaction that was added to account-4 and connected to account-16.

After a while, I found that transaction-X was displayed in account-4, but not being displayed and calculated in account-16.

In account-4, if I double click transaction-X to open the edit dialog, I see account-16 properly shown in the "From account:" field. If I then click the "From account:" arrow button twice (once to open the selection, second to close the selection, without any changes to the field value), transaction-X appears in account-4 and gets calculated properly.

Given the number of changes I made, I can't say how to reproduce the problem, but I'll see what else I can find. More info is below, along with (hopefully) relevant snippets from my XHB file:

Version: Homebank 5.0.3
OS: Windows 7
XML Snippets:
<homebank v="1.1000000000000001">
<account key="4" flags="32" pos="11" type="5" name="account 4" initial="0" minimum="0" />
<account key="16" flags="32" pos="21" type="5" name="account 16" initial="0" minimum="0" />
<cat key="73" name="category 73" />
<ope date="735779" amount="5434" account="4" dst_account="16" paymode="5" flags="2" category="73" wording="memo 735779" kxfer="189" />

[Kinnin Vo-Shay (vo-shay)]

Looked into this a bit more, I found that if I went through the my steps of making the other half of the transaction show up by clicking the "From account:", account-4 shows an edit icon but I'm not able to save the file. Homebank doesn't think there are any changes.

If I changed transaction-X's payment type to something else however, then change it back to "Internal Transfer", the calculations are again fixed, but now I am able to save changes to the file. After saving, the file now has this added line showing the other half of the transaction that was missing:

<ope date="735779" amount="-5434" account="16" dst_account="4" paymode="5" st="2" category="73" wording="memo 735779" kxfer="189" />

So somewhere along the way, transaction-X didn't have both sides of its Internal Transfer saved, but I don't know how. Given that problem, there seem to be a couple more issues worth looking at:
- Despite the internal transfer data being corrupted, that corruption wasn't detected, even though there is enough data in half the transaction to look for the other half and say if it is missing.
- Certain actions caused Homebank to fix its display & calculations but not fully update its internal state to recognize that changes need to be saved to disk (my "From account" changes).

[Maxime DOYEN (mdoyen)]

we probably never know what happen. Probably a bug at a time and the consistency was not reevaluated on that area.
it is now done.

[Maxime DOYEN (mdoyen)]

I partially revert the fix back (the part that create some missing int xfer), as it generate some trouble to other users.
I have fixed other part, the count change in case of consistency is evaluated.

[Kinnin Vo-Shay (vo-shay)]

I can understand why you had to partially back out the change. I tried 5.0.4 and then had to do some clean up where the consistency checking resulted in new unwanted transactions.

I knew why this had happened because I expected the bug fix and it wasn't a surprise to me, but generally it might be better to have some user notification/input. Rather than Homebank automatically creating missing internal xfers without any notification, Homebank can tell the user its found inconsistencies and ask whether to fix them. If the user says yes, create the missing xfers and make sure to mark the new/changed entries with appropriate icons (e.g. see attached)

[Maxime DOYEN (mdoyen)]

commited.
I finally made a menu from register/account windows to check things manually.
Use Action menu, check internal xfer, any changes will be under control