deep_merge gem package

[Alex Schultz]

In order to enable the 'deeper' merge behavior in hiera[0], we need the deep_merge gem[1] packaged and available.

[0] https://bugs.launchpad.net/fuel/+bug/1462528
[1] https://rubygems.org/gems/deep_merge/

[Artem Silenkov (asilenkov)]

What version, what ruby version and what OS you want ?

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: master
Change author: Artem Silenkov <email address hidden>
Review: https://review.fuel-infra.org/7970

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7970
Submitter: Andrey Nikitin <email address hidden>
Branch: master

Commit: cb6b5cdfad4ac6bb3d3c0b2be243b33ccd28b620
Author: Artem Silenkov <email address hidden>
Date: Fri Jun 19 16:07:04 2015

ruby-deep-merge packaged for centos6 and trusty

Change-Id: I88c81185844ba630173568198df8c2abbc054f01
Related-Bug: #1464766

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 7.0
Change author: Artem Silenkov <email address hidden>
Review: https://review.fuel-infra.org/7971

[Matthew Mosesohn (raytrac3r)]

We probably shouldn't add any deps to puppet or hiera, but instead add it to fuel-library6.1 package

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7971
Submitter: Artem Silenkov <email address hidden>
Branch: 7.0

Commit: 7956f84565469469b9ed0b8149a26d3ad85aaeaa
Author: Artem Silenkov <email address hidden>
Date: Fri Jun 19 16:33:03 2015

Rubygem ruby-deep-merge is packaged for 7.0

Change-Id: I139e20e359486b03df0c7d84c9a496a11e3affb9
Related-Bug: #1464766

[Matthew Mosesohn (raytrac3r)]

Actually, that doesn't get installed on nodes. Let's add it as a dep for fuel-misc here https://github.com/stackforge/fuel-library/blob/master/specs/fuel-library7.0.spec#L131

[Artem Silenkov (asilenkov)]

@mos-linux
Please help to package it. I'm not sure how to name and version it right way.
Take care that we need v1.0.1

[Alexei Sheplyakov (asheplyakov)]

Adding new packages into the stable release is not such a good idea. Perhaps this bug should be marked as Won't Fix for MOS 6.1.x

[Alex Schultz (alex-schultz)]

We need this for 6.1 as we will be doing a customized 6.1 deploy for a customer which will require this package. There is no harm in adding a package to an existing release if it is not referenced anywhere.

[Alexei Sheplyakov (asheplyakov)]

> There is no harm in adding a package to an existing release

That's incorrect. Adding new packages to a stable release violates the definition of "stable" (which is
roughly "no new packages, no package removals, no updates to a newer upstream version, no downgrades").

> if it is not referenced anywhere

Somebody will reference it or assume it's always available. In general anything that can, could have,
or will go wrong, is going wrong, all at once.

[Alex Schultz (alex-schultz)]

Fair enough, the question still remains how does one get a package built for a version of the software that we have built that will be needed for a deployment based on that stable version... I believe a package built that is currently targeted for 7.0 should suffice. But I need the package so can I please have some help getting the package built? If the current assignments are incorrect, please update them to someone who can assist. Thanks.

[Matthew Mosesohn (raytrac3r)]

What is the status of the MOS 7.0 ruby-deep-merge package for Ubuntu?

[Aleksander Mogylchenko (amogylchenko)]

Sorry, I had other priorities. Will work on the package today.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: 7.0
Change author: Aleksandr Mogylchenko <email address hidden>
Review: https://review.fuel-infra.org/8870

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 7.0
Change author: Aleksandr Mogylchenko <email address hidden>
Review: https://review.fuel-infra.org/8875

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: 7.0
Change author: Aleksandr Mogylchenko <email address hidden>
Review: https://review.fuel-infra.org/8876

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Aleksandr Mogylchenko <email address hidden> on branch: 7.0
Review: https://review.fuel-infra.org/8875
Reason: update to fix CVE will be provided in different CR

[Aleksander Mogylchenko (amogylchenko)]

CRs #8870 and #8876 are required for this, and are in review right now.

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/8870
Submitter: Michael Semenov <email address hidden>
Branch: 7.0

Commit: 37f164ac7e8b88f5ca07ee27803ea580666737a7
Author: Aleksandr Mogylchenko <email address hidden>
Date: Tue Jun 30 12:50:42 2015

Add deep_merge Ruby package to MOS 7.0

This package is needed to allow ':merge_behavior: deeper' in Hiera, which
is required for BP:
https://blueprints.launchpad.net/fuel/+spec/detach-components-from-controllers

Separate change to recommend ruby-deep-merge is done:
https://review.fuel-infra.org/#/c/8876/

Source:
https://github.com/danielsdeleo/deep_merge/commit/f9df6fdb0d0090318e8015814e68e5ca2973b493

Related-Bug: #1464766
Change-Id: I6bed981182a3fded88a0880cfd8870260a2585da

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/8876
Submitter: Michael Semenov <email address hidden>
Branch: 7.0

Commit: 2dd8dbb4414687756ea9e71a1732231dfe15b504
Author: Aleksandr Mogylchenko <email address hidden>
Date: Tue Jun 30 12:39:57 2015

Add 'Recommends:' field on ruby-deep-merge for Hiera.

Ruby-deep-merge allows using ':merge_behavior: deeper' in Hiera, and field
solves the problem with dependencies.

Related-Bug: #1464766
Related-Bug: #1462528
Change-Id: I0d1000fc853ce4be58b188cb9d3ebb588d7826f7

[Aleksander Mogylchenko (amogylchenko)]

Merged.

[Matthew Mosesohn (raytrac3r)]

Back to open. Let's get the centos package in too. Ubuntu is ready but no CentOS.

[Aleksander Mogylchenko (amogylchenko)]

@Matthew, CentOS package was merged on June 19, here is the CR:
https://review.fuel-infra.org/#/c/7971/

[Alex Schultz (alex-schultz)]

We're waiting for the perestroika cutover before we can close this as the packages were not build via OBS

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/193639
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=5f4303958f07a51eb6ce52ecf796fa4a8152490f
Submitter: Jenkins
Branch: master

commit 5f4303958f07a51eb6ce52ecf796fa4a8152490f
Author: Alex Schultz <email address hidden>
Date: Fri Jun 19 11:57:46 2015 -0500

    Add ruby-deep-merge to requirements

    In order to support the 'deeper' merge behavior in hiera, we need the
    deep_merge gem available to puppet. This is required to allow for
    overriding our heira.

    Change-Id: I8e72af25db29d558b7fcd30be7ee7de3e581aecc
    Related-Bug: 1462528
    Related-Bug: 1464766

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/193636
Reason: this won't solve the issue as we don't need to install it on the fuel master, need a different method to target only the non-fuel master nodes

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/204769

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/204769
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=8e8a2af711dc0304aaf90b4a4589de8750d46196
Submitter: Jenkins
Branch: master

commit 8e8a2af711dc0304aaf90b4a4589de8750d46196
Author: Alex Schultz <email address hidden>
Date: Wed Jul 22 16:23:37 2015 -0500

    Install rubygem-deep_merge as part of hiera task

    This change adds the installation of the deep_merge package as part of
    the hiera configuration to enable the deeper merge behaviour.

    Change-Id: I62dd9f612e1533d0406affa5d1a820680ba2a509
    Related-Bug: 1462528
    Related-Bug: 1464766

[Dmitry Borodaenko (angdraug)]

Looks like a duplicate of bug #1462528.

[Aleksander Mogylchenko (amogylchenko)]

Dmitriy, this bug is about gem package itself. Bug #1462528 is about enabling functionality that this gem provides.

[Alex Schultz (alex-schultz)]

The packages have been built and are available

[Vladimir Khlyunev (vkhlyunev)]

ISO 301 (RC4) - verified

root@node-1:~# dpkg -s ruby-deep-merge
Package: ruby-deep-merge
Status: install ok installed
Priority: optional
Section: ruby
Installed-Size: 77
Maintainer: MOS Linux team <email address hidden>
Architecture: all
Version: 1.0.0+git20150630-1~u14.04+mos1
Depends: ruby | ruby-interpreter
Description: Deep Merge is a simple set of utility functions for Hash.
  It permits you to merge elements inside a hash together recursively.
Ruby-Versions: ruby1.9.1 ruby2.0
root@node-1:~#