Incorrect nrpe checks: ext-port, os-charm-phy-nic-mtu

[Alvaro Uria]

Hi,

* ext-port and os-charm-phy-nic-mtu configuration files (stored in charm templates directory) are copied in /etc/init/:
- http://bazaar.launchpad.net/~openstack-charmers/charms/trusty/neutron-gateway/trunk/files/head:/templates/
- http://bazaar.launchpad.net/~openstack-charmers/charms/trusty/neutron-gateway/trunk/view/head:/hooks/neutron_utils.py#L274

* When nrpe-external-master relation is added to quantum-gateway, all checks in /etc/init use check_upstart_job.py:
- http://bazaar.launchpad.net/~openstack-charmers/charms/precise/quantum-gateway/trunk/view/head:/hooks/quantum_hooks.py#L281
- http://bazaar.launchpad.net/~openstack-charmers/charm-helpers/stable/view/head:/charmhelpers/contrib/charmsupport/nrpe.py#L292

However, ext-port and os-charm-phy-nic-mtu are task scripts run at boot time (to fix mtu value) and check_upstart_job (and initctl list) show both services as "stopped/waiting".

Shouldn't those 2 /etc/init scripts be moved in /etc/network/interfaces.d and nrpe-check if "ip link show $DEV" is in state UP?

Please let me know if I can help you more.

Cheers,
-Alvaro.

PS: bug moved from quantum-gateway to neutron-gateway project
I see,
http://bazaar.launchpad.net/~openstack-charmers/charms/trusty/neutron-gateway/trunk/view/head:/hooks/neutron_utils.py#L523
This bug should probably be closed.

[Alvaro Uria (aluria)]

Merge proposal has been sent to modify lp:charm-helpers.
https://code.launchpad.net/~brad-marshall/charm-helpers/remove-neutron-gateway-checks/+merge/277935

[Liam Young (gnuoy)]

I'm going to mark this as fix committed since the nrpe workaround has landed and the upstart scripts are being dropped for xenial+