sandesh client code needs to move to use size based watermarks

Bug #1464040 reported by Megh Bhatt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Won't Fix
High
Arvind
Trunk
Fix Committed
High
Arvind

Bug Description

Recently size based water mark support was added in WorkQueue but looks like the sandesh c++ client code is still using message count based water marks. Its better to move it to size based water marks

Megh Bhatt (meghb)
tags: added: quench
Raj Reddy (rajreddy)
Changed in juniperopenstack:
assignee: Megh Bhatt (meghb) → Arvind (arvindv)
milestone: r2.30-fcs → r2.22
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13752
Submitter: Arvind (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13752
Committed: http://github.org/Juniper/contrail-sandesh/commit/5ed5df0c5456df726e0af735dbb99627de812005
Submitter: Zuul
Branch: R2.22-dev

commit 5ed5df0c5456df726e0af735dbb99627de812005
Author: arvindvis <email address hidden>
Date: Thu Sep 10 16:47:53 2015 -0700

This fix changes the sandesh send queue size based on
the actual message size upon enque/dequeue.

Compiler:
---------
Sandesh compiler is changed to generate GetSize()
which returns the size of the sandesh

Library:
-------
Introducing a new structure Element which consists of the
sandesh and GetSize function to return size of sandesh

Change the sandesh_queue_.Enqueue and Dequeue to take
Element as argument and not sandesh

Test if Sandesh GetSize function returns value properly.
Test if sandesh queue size changes
by the message size upon enqueue/dequeue

Change-Id: Idcd4a9e47e2e0a14601a1963098aa83c2f8c2d93
Closes-Bug: #1464040

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/14072
Submitter: Arvind (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/14072
Committed: http://github.org/Juniper/contrail-sandesh/commit/e4478433c64d8691550e1064628770ec8d652691
Submitter: Zuul
Branch: master

commit e4478433c64d8691550e1064628770ec8d652691
Author: arvindvis <email address hidden>
Date: Fri Sep 25 15:37:23 2015 -0700

This fix changes the sandesh send queue size based on
the actual message size upon enque/dequeue.

Compiler:
---------
Sandesh compiler is changed to generate GetSize()
which returns the size of the sandesh

Library:
-------
Introducing a new structure Element which consists of the
sandesh and GetSize function to return size of sandesh

Change the sandesh_queue_.Enqueue and Dequeue to take
Element as argument and not sandesh

Test if Sandesh GetSize function returns value properly.
Test if sandesh queue size changes
by the message size upon enqueue/dequeue

Change-Id: I274e976a5807e5bdd7d4ddfc647ffea20ffa0399
Closes-Bug: #1464040

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.