Make bgp_stress_test more robust

Bug #1464016 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Released
Medium
Nischal Sheth
R3.0
Fix Committed
Medium
Nischal Sheth
R3.0.2.x
Invalid
Medium
Nischal Sheth
R3.1
Fix Committed
Medium
Nischal Sheth
R3.2
Fix Committed
Medium
Nischal Sheth
Trunk
Fix Committed
Medium
Nischal Sheth

Bug Description

Tracking bug for improvements/fixes to bgp_stress_test.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/11472
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/11473
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11472
Committed: http://github.org/Juniper/contrail-controller/commit/a02166fec6d1feeaa465879037b00d03868e211e
Submitter: Zuul
Branch: R2.20

commit a02166fec6d1feeaa465879037b00d03868e211e
Author: Nischal Sheth <email address hidden>
Date: Wed Jun 10 09:50:59 2015 -0700

Make BgpStressTest::VerifyRoutingInstances more robust

Change-Id: Iea91ad3107c8782dc6f0661cfd3cafaabcc18323
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11473
Committed: http://github.org/Juniper/contrail-controller/commit/2dd93f26fa5b15b6fbe4a462057201a8a1bf4a7c
Submitter: Zuul
Branch: master

commit 2dd93f26fa5b15b6fbe4a462057201a8a1bf4a7c
Author: Nischal Sheth <email address hidden>
Date: Wed Jun 10 09:50:59 2015 -0700

Make BgpStressTest::VerifyRoutingInstances more robust

Change-Id: Iea91ad3107c8782dc6f0661cfd3cafaabcc18323
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/11577
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/11578
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11577
Committed: http://github.org/Juniper/contrail-controller/commit/1da66de73ca881922f36fc37221366394d1e439d
Submitter: Zuul
Branch: master

commit 1da66de73ca881922f36fc37221366394d1e439d
Author: Nischal Sheth <email address hidden>
Date: Fri Jun 12 16:38:28 2015 -0700

Increase open timer for Bgp/Xmpp state machine used in tests

Xmpp server state machine starts the open timer after receiving passive
open and closes the session if it doesn't get an open message before it
expires.

Bgp state machine starts the open timer after receiving passive open in
order to implement a delayed open on the passive side. This should not
be required in normal cases if the active side sends an open right away.

Hence there's no need to use very small values for the open timer during
integration tests.

Change-Id: I32ab7931342dfbefd2266116377b98699702d8dc
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11578
Committed: http://github.org/Juniper/contrail-controller/commit/2865a4dba70210d9a4b17242f33bc7c38226db4d
Submitter: Zuul
Branch: R2.20

commit 2865a4dba70210d9a4b17242f33bc7c38226db4d
Author: Nischal Sheth <email address hidden>
Date: Fri Jun 12 16:38:28 2015 -0700

Increase open timer for Bgp/Xmpp state machine used in tests

Xmpp server state machine starts the open timer after receiving passive
open and closes the session if it doesn't get an open message before it
expires.

Bgp state machine starts the open timer after receiving passive open in
order to implement a delayed open on the passive side. This should not
be required in normal cases if the active side sends an open right away.

Hence there's no need to use very small values for the open timer during
integration tests.

Change-Id: I32ab7931342dfbefd2266116377b98699702d8dc
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12034
Submitter: Ananth Suryanarayana (<email address hidden>)

1 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12035
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12036
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12034
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12034
Committed: http://github.org/Juniper/contrail-controller/commit/e2eeebcd7fac812def9e7b89e102aadc8792e169
Submitter: Zuul
Branch: master

commit e2eeebcd7fac812def9e7b89e102aadc8792e169
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Jun 25 11:38:38 2015 -0700

Partial-Bug: 1464016 Add bgp routes with unique RDs for all bgp peers

1. Each BGP peer sends its own route : n_peers_
2. Each Agent sends its own route per instance: nagents * ninstances
3. Per agent route, one route is injected by 1/2 bgp peers with same rd
: nagents * ninstances
4. Per agent route, one route is injected by 1/2 bgp peers with different rds
: nagents * ninstances * n_peers_/2

Sum: n_peers_ + nagents * ninstances * (1 + 1 + n_peers_/2)
Expected: nroutes * (n_peers_ + nagents * ninstances * (2 + n_peers_/2))

For inet6, for part 1, half peers ended up with the same rd, thus causing the
table to have only n_peers_/2 bgp routes. This same/different rd applies only
to part 3 and 4.

Change-Id: I2904c615e175f16c6c20f48f75a4fb509b56320c

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12035
Committed: http://github.org/Juniper/contrail-controller/commit/9fdbb230aaf16669c0e549953e0d6d4d5b5c233b
Submitter: Zuul
Branch: master

commit 9fdbb230aaf16669c0e549953e0d6d4d5b5c233b
Author: Nischal Sheth <email address hidden>
Date: Wed Jun 24 17:27:10 2015 -0700

Use correct API to clear a BgpPeer

Change-Id: Ie7dec149434ee82c842650aea4b87e0f35d070b3
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12036
Committed: http://github.org/Juniper/contrail-controller/commit/acb77f2650721227ad8232bd2f94b816975b0078
Submitter: Zuul
Branch: R2.20

commit acb77f2650721227ad8232bd2f94b816975b0078
Author: Nischal Sheth <email address hidden>
Date: Wed Jun 24 17:27:10 2015 -0700

Use correct API to clear a BgpPeer

Change-Id: Ie7dec149434ee82c842650aea4b87e0f35d070b3
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12064
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12108
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12109
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12108
Committed: http://github.org/Juniper/contrail-controller/commit/9ab754f829aa360e100438eea803e2cd2e0105f5
Submitter: Zuul
Branch: master

commit 9ab754f829aa360e100438eea803e2cd2e0105f5
Author: Nischal Sheth <email address hidden>
Date: Tue Jun 30 11:36:20 2015 -0700

Improve bgp_stress_test teardown code

If the XmppServer is shutdown before the agents, the agents keep
trying to connect to it continuously and keep the scheduler busy.
Instead, cleanup the agents first and then shutdown XmppServer.

Change-Id: Iea6a65c907f4dddbc5f42c787e4d3974ffd6f3b2
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12109
Committed: http://github.org/Juniper/contrail-controller/commit/093407c7a12ea7af529db61d1b3ddc6686340096
Submitter: Zuul
Branch: R2.20

commit 093407c7a12ea7af529db61d1b3ddc6686340096
Author: Nischal Sheth <email address hidden>
Date: Tue Jun 30 11:36:20 2015 -0700

Improve bgp_stress_test teardown code

If the XmppServer is shutdown before the agents, the agents keep
trying to connect to it continuously and keep the scheduler busy.
Instead, cleanup the agents first and then shutdown XmppServer.

Change-Id: Iea6a65c907f4dddbc5f42c787e4d3974ffd6f3b2
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12202
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12204
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12205
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12206
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12202
Committed: http://github.org/Juniper/contrail-controller/commit/70ba23adc7dee9cbb4870c06b92a8d4ee3327b1a
Submitter: Zuul
Branch: master

commit 70ba23adc7dee9cbb4870c06b92a8d4ee3327b1a
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Jul 6 13:48:12 2015 -0700

Partial-Bug: 1464016 RD should not contain number in hex format

Fore IPv6, RDs were generated in <as>:<number> format with <number> in hex form.
<number> should instead be in decimal format

Change-Id: I6c735642fc95064b9520f1a718af52cf66272f9f

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12206
Committed: http://github.org/Juniper/contrail-controller/commit/c63cf4ae6d933ddfa4385a3a56d39330f98656b8
Submitter: Zuul
Branch: master

commit c63cf4ae6d933ddfa4385a3a56d39330f98656b8
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Jul 6 15:12:37 2015 -0700

Partial-Bug: 1464016 Add hook via env to bgp_stress_test to set number of events

bgp_stress_test_suite runs tests with either default number of events (50) or
higher. Have a way to change this from outside via env BGP_STRESS_TEST_NEVENTS.
If set to -1, only initial test setup is executed and no other events are
injected.

Change-Id: I84827aa3aba29b0da37647e469b33cb573e9ed0f

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12256
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12256
Committed: http://github.org/Juniper/contrail-controller/commit/63983145b6e7352c1349ef4e5fb31ef22dadb7a2
Submitter: Zuul
Branch: master

commit 63983145b6e7352c1349ef4e5fb31ef22dadb7a2
Author: Nischal Sheth <email address hidden>
Date: Tue Jul 7 16:23:47 2015 -0700

Add unidimensional stress test with 127 agents

Change-Id: I72b9a143305a62ab5870955007fe5f4e29211dd5
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12204
Committed: http://github.org/Juniper/contrail-controller/commit/bfa1ddd37c1abd0ff6d2b913f5eef423f2785e1e
Submitter: Zuul
Branch: R2.20

commit bfa1ddd37c1abd0ff6d2b913f5eef423f2785e1e
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Jul 6 15:10:29 2015 -0700

Partial-Bug: 1464016 RD should not contain number in hex format

Fore IPv6, RDs were generated in <as>:<number> format with <number> in hex form.
<number> should instead be in decimal format

Change-Id: I2786f8dd18d8db91d866f3dc4102c0b1df3a64a1

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12205
Committed: http://github.org/Juniper/contrail-controller/commit/08839ede4ed86e177cc9ccf8bff3c8a00da1db88
Submitter: Zuul
Branch: R2.20

commit 08839ede4ed86e177cc9ccf8bff3c8a00da1db88
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Jul 6 15:12:37 2015 -0700

Partial-Bug: 1464016 Add hook via env to bgp_stress_test to set number of events

bgp_stress_test_suite runs tests with either default number of events (50) or
higher. Have a way to change this from outside via env BGP_STRESS_TEST_NEVENTS.
If set to -1, only initial test setup is executed and no other events are
injected.

Change-Id: I84827aa3aba29b0da37647e469b33cb573e9ed0f

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12064
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/12289
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/12064
Committed: http://github.org/Juniper/contrail-controller/commit/663b2d6ff750352e93e13599baa014d4f9c554d8
Submitter: Zuul
Branch: R2.20

commit 663b2d6ff750352e93e13599baa014d4f9c554d8
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Jun 25 11:38:38 2015 -0700

Partial-Bug: 1464016 Add bgp routes with unique RDs for all bgp peers

1. Each BGP peer sends its own route : n_peers_
2. Each Agent sends its own route per instance: nagents * ninstances
3. Per agent route, one route is injected by 1/2 bgp peers with same rd
: nagents * ninstances
4. Per agent route, one route is injected by 1/2 bgp peers with different rds
: nagents * ninstances * n_peers_/2

Sum: n_peers_ + nagents * ninstances * (1 + 1 + n_peers_/2)
Expected: nroutes * (n_peers_ + nagents * ninstances * (2 + n_peers_/2))

For inet6, for part 1, half peers ended up with the same rd, thus causing the
table to have only n_peers_/2 bgp routes. This same/different rd applies only
to part 3 and 4.

Change-Id: I2904c615e175f16c6c20f48f75a4fb509b56320c

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/12289
Committed: http://github.org/Juniper/contrail-controller/commit/47e5c7551f87e467dce49dd1563a6b63d061baeb
Submitter: Zuul
Branch: R2.20

commit 47e5c7551f87e467dce49dd1563a6b63d061baeb
Author: Nischal Sheth <email address hidden>
Date: Tue Jul 7 16:23:47 2015 -0700

Add unidimensional stress test with 127 agents

Change-Id: I72b9a143305a62ab5870955007fe5f4e29211dd5
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12670
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12671
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12670
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/12671
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/12675
Submitter: Ananth Suryanarayana (<email address hidden>)

29 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/13077
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/13076
Submitter: Ananth Suryanarayana (<email address hidden>)

1 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13076
Committed: http://github.org/Juniper/contrail-controller/commit/773fe2c7955208684d6dd9d11985bedf6f15e58f
Submitter: Zuul
Branch: master

commit 773fe2c7955208684d6dd9d11985bedf6f15e58f
Author: Ananth Suryanarayana <email address hidden>
Date: Fri Aug 14 10:58:31 2015 -0700

Ignore non-effective logging and counting events
e.g. Deletiin of an instance which is already deleted
o Build bgp_stress_test with optimization turned on (linkage issue)
o Add an option to print traces --log-trace-enable (Default: FALSE)
o To help convergence, advertise routes from agents only after subscription
is complete (With simple WaitForIdle() which is not perfect though..
o Wait for server_->get_output_queue_depth() to reach 0 during initial convergence

Change-Id: I412b73bad6b3267964e528ea1bf373a071bd354d
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13486
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/13486
Committed: http://github.org/Juniper/contrail-controller/commit/300d3b5ea763347107fc88937bea3078e5e9007f
Submitter: Zuul
Branch: R2.22-dev

commit 300d3b5ea763347107fc88937bea3078e5e9007f
Author: Ananth Suryanarayana <email address hidden>
Date: Fri Aug 14 10:58:31 2015 -0700

Ignore non-effective logging and counting events
e.g. Deletion of an instance which is already deleted
o Build bgp_stress_test with optimization turned on (linkage issue)
o Add an option to print traces --log-trace-enable (Default: FALSE)
o To help convergence, advertise routes from agents only after subscription
is complete (With simple WaitForIdle() which is not perfect though..
o Wait for server_->get_output_queue_depth() to reach 0 during initial convergence

Change-Id: I412b73bad6b3267964e528ea1bf373a071bd354d
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/14930
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/14930
Committed: http://github.org/Juniper/contrail-controller/commit/7ba8db8b6754e2e5939b6ce35d54941c890efbf4
Submitter: Zuul
Branch: master

commit 7ba8db8b6754e2e5939b6ce35d54941c890efbf4
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Nov 5 01:51:28 2015 -0800

Update instances_ when working with external control-node

Found an issue with using bgp_stress_test against an external
control-node. Subscription and routes send did not happen
as expected

Change-Id: If71d669ba4c70f4f0d9e27dd11d5b8f8075f2269
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/21627
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/21629
Submitter: Ananth Suryanarayana (<email address hidden>)

1 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/21627
Committed: http://github.org/Juniper/contrail-controller/commit/2db567bed663b84f8359bba2486082bf2946544a
Submitter: Zuul
Branch: master

commit 2db567bed663b84f8359bba2486082bf2946544a
Author: Ananth Suryanarayana <email address hidden>
Date: Fri Jul 1 10:33:34 2016 -0700

Add TCP_KEEPALIVE_SECONDS env based option

TCP_KEEPALIVE_SECONDS value of 0 disables tcp keepalives.

Change-Id: Iedcc06d5a8cb4b3958c23108b120ad3d15fee533
Partial-Bug: #1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.2.x

Review in progress for https://review.opencontrail.org/22160
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22161
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22162
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/22161
Committed: http://github.org/Juniper/contrail-controller/commit/c7526418d9322156194b9abefff575a0d2384409
Submitter: Zuul
Branch: master

commit c7526418d9322156194b9abefff575a0d2384409
Author: Ananth Suryanarayana <email address hidden>
Date: Tue Jul 19 13:07:07 2016 -0700

Add ability to selectively skip sending xmpp updates

In scaled setups, we want to minimuze cpu consumed by actual data send over
tcp. Instead of sending and dropping right after read at the receiver end,
we can have an option not send data at all.

This was there, but limited as a binary option. With this change, one can filter
destinations to which the updates send must be skipped, based on regex pattern
match as specified in the environment variable XMPP_SKIP_UPDATE_SEND

Change-Id: I078887186e6df2fb7be5b7a6b6b44d7c40a7e6e8
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.2.x

Review in progress for https://review.opencontrail.org/22160
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22162
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22238
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/22239
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/22238
Submitter: Ananth Suryanarayana (<email address hidden>)

1 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/22291
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/22292
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0.2.x

Review in progress for https://review.opencontrail.org/22293
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/21629
Committed: http://github.org/Juniper/contrail-controller/commit/fed8570093f5e77acf1d4af8f829da7c201fd171
Submitter: Zuul
Branch: R3.0

commit fed8570093f5e77acf1d4af8f829da7c201fd171
Author: Ananth Suryanarayana <email address hidden>
Date: Fri Jul 1 10:33:34 2016 -0700

Add TCP_KEEPALIVE_SECONDS env based option

TCP_KEEPALIVE_SECONDS value of 0 disables tcp keepalives.

Change-Id: Iedcc06d5a8cb4b3958c23108b120ad3d15fee533
Partial-Bug: #1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22238
Committed: http://github.org/Juniper/contrail-controller/commit/7c511ac74a89e0f5cfee56a1dd3399900f112ae4
Submitter: Zuul
Branch: master

commit 7c511ac74a89e0f5cfee56a1dd3399900f112ae4
Author: Ananth Suryanarayana <email address hidden>
Date: Wed Jul 20 16:15:36 2016 -0700

Cache regex pattern matches for XMPP_SKIP_UPDATE_SEND pattern

Regex pattern matching can be expensive. Hence cache the result inside
BgpXmppChannel object to avoid redundant regex evaluatiob.

Change-Id: I3fb1f5a8b4d9a3db6e25376cecd0ac774a2b9639
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22291
Committed: http://github.org/Juniper/contrail-controller/commit/c730ad2c1bea9f099f35cec42c6d5087ebdd8e3c
Submitter: Zuul
Branch: R3.0

commit c730ad2c1bea9f099f35cec42c6d5087ebdd8e3c
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Jul 21 12:16:33 2016 -0700

Cache regex pattern matches for XMPP_SKIP_UPDATE_SEND pattern

Regex pattern matching can be expensive. Hence cache the result inside
BgpXmppChannel object to avoid redundant regex evaluation.

Change-Id: I85f136e273b045284c32a1cecff7a41f3dcb0054
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/22292
Committed: http://github.org/Juniper/contrail-controller/commit/04a2bf15a9ad4e153893c8ca888663891fbcd0f5
Submitter: Zuul
Branch: R3.1

commit 04a2bf15a9ad4e153893c8ca888663891fbcd0f5
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Jul 21 12:16:33 2016 -0700

Cache regex pattern matches for XMPP_SKIP_UPDATE_SEND pattern

Regex pattern matching can be expensive. Hence cache the result inside
BgpXmppChannel object to avoid redundant regex evaluation.

Change-Id: I85f136e273b045284c32a1cecff7a41f3dcb0054
Partial-Bug: 1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/23825
Submitter: Ananth Suryanarayana (<email address hidden>)

2 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/23825
Committed: http://github.org/Juniper/contrail-controller/commit/6b17e4f39b2719fe2803f8db1ac514aa4fe00b82
Submitter: Zuul
Branch: master

commit 6b17e4f39b2719fe2803f8db1ac514aa4fe00b82
Author: Ananth Suryanarayana <email address hidden>
Date: Thu Sep 1 12:25:20 2016 -0700

Delete routes before unsubscribing from an instance

Production code agent does this and control-node expects this as well, from
any subscribed agent (mock or otherwise). Otherwise routes can remain undeleted
in the control-node's table (until the session flaps), or routes are explicitly
deleted.

But some tests still need routes not to be deleted during unsubscribe. Add an
argument to support this functionality to Unsubscribe() API of the mock agent
and use it in tests as necessary.

Also add security-group id to advertised routes. One can set --nsgids to a
desired number. route-id % nsgids is used as the actual sgid advertised. By
increasing nsgids, one can get different sgids across a given set of routes.

Mock-agent code also does not run eor timers (but uses BgpXmppChannel object)
Add necessary protection while cancelling the timer

Change-Id: Ic4f7ed2f0645151a7521130c09bb378418bc605a
Partial-Bug: #1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24083
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/24083
Committed: http://github.org/Juniper/contrail-controller/commit/acbee94b0ac13218eebcb478cbcbea10a5df77b5
Submitter: Zuul
Branch: master

commit acbee94b0ac13218eebcb478cbcbea10a5df77b5
Author: Ananth Suryanarayana <email address hidden>
Date: Mon Sep 12 11:59:52 2016 -0700

Generate enet address from ip-address correctly

Convert IPv4 address in dotted decimal format to hex-based
mac-address with : format. (and append 00:00)

Change-Id: I9a8bd4a50d81be2f91dd029fd6742f55042f7c94
Partial-Bug: #1464016

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/24759
Submitter: Ananth Suryanarayana (<email address hidden>)

2 comments hidden view all 109 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/25246
Submitter: Ananth Suryanarayana (<email address hidden>)

Displaying first 40 and last 40 comments. View all 109 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.