[upgrade] Re-deployment of env with mongo nodes failed after upgrade

[Andrey Sledzinskiy]

{

    "build_id": "2015-06-08_06-13-27",
    "build_number": "521",
    "release_versions":

{

    "2014.2-6.0":

{

    "VERSION":

{

    "build_id": "2014-12-26_14-25-46",
    "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4",
    "build_number": "58",
    "api": "1.0",
    "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90",
    "production": "docker",
    "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8",
    "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91",
    "feature_groups":

        [
            "mirantis"
        ],
        "release": "6.0",
        "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"
    }

},
"2014.2.2-6.1":
{

    "VERSION":

{

    "build_id": "2015-06-08_06-13-27",
    "build_number": "521",
    "api": "1.0",
    "fuel-library_sha": "f43c2ae1af3b493ee0e7810eab7bb7b50c986c7d",
    "nailgun_sha": "4340d55c19029394cd5610b0e0f56d6cb8cb661b",
    "feature_groups":

            [
                "mirantis"
            ],
            "openstack_version": "2014.2.2-6.1",
            "production": "docker",
            "python-fuelclient_sha": "4fc55db0265bbf39c369df398b9dc7d6469ba13b",
            "astute_sha": "7766818f079881e2dbeedb34e1f67e517ed7d479",
            "fuel-ostf_sha": "7c938648a246e0311d05e2372ff43ef1eb2e2761",
            "release": "6.1",
            "fuelmain_sha": "bcc909ffc5dd5156ba54cae348b6a07c1b607b24"
        }
    }

},
"auth_required": true,
"api": "1.0",
"fuel-library_sha": "f43c2ae1af3b493ee0e7810eab7bb7b50c986c7d",
"nailgun_sha": "4340d55c19029394cd5610b0e0f56d6cb8cb661b",
"feature_groups":

    [
        "mirantis"
    ],
    "openstack_version": "2014.2.2-6.1",
    "production": "docker",
    "python-fuelclient_sha": "4fc55db0265bbf39c369df398b9dc7d6469ba13b",
    "astute_sha": "7766818f079881e2dbeedb34e1f67e517ed7d479",
    "fuel-ostf_sha": "7c938648a246e0311d05e2372ff43ef1eb2e2761",
    "release": "6.1",
    "fuelmain_sha": "bcc909ffc5dd5156ba54cae348b6a07c1b607b24"

}

Steps:
1. Create simple 6.0-58 cluster - simple, Neutron Vlan, ceph for volumes, Sahara, Ceilometer, 1 controller, 2 compute, 2 ceph, 3 mongo
2. Deploy cluster
3. Upgrade to 6.1
4. Add compute node to 6.0 cluster and re-deploy

Actual result - it failed with
[7fba2aaec740] (manager) Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/nailgun/task/manager.py", line 58, in _call_silently
    to_return = method(task, *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/nailgun/task/task.py", line 805, in execute
    cls._check_mongo_nodes(task)
  File "/usr/lib/python2.6/site-packages/nailgun/task/task.py", line 969, in _check_mongo_nodes
    and components["mongo"]["value"]
KeyError: 'mongo'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/190252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/190252
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=e191012ee67bceed80acd114e440f51f15534dc8
Submitter: Jenkins
Branch: master

commit e191012ee67bceed80acd114e440f51f15534dc8
Author: Igor Kalnitsky <email address hidden>
Date: Wed Jun 10 19:37:47 2015 +0300

    Do not run mongo checks for old releases

    In Fuel releases before 6.1 we didn't have 'external mongo' feature,
    and therefore running mongo checks is invalid operation.

    Closes-Bug: #1463880

    Change-Id: I58dd0ebd6de610448bf297d0bd97c6a334f6abc0
    Signed-off-by: Igor Kalnitsky <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/190648

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/190648
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=e42b7db476b0ace256d09d95d49b184d555095b4
Submitter: Jenkins
Branch: stable/6.1

commit e42b7db476b0ace256d09d95d49b184d555095b4
Author: Igor Kalnitsky <email address hidden>
Date: Wed Jun 10 19:37:47 2015 +0300

    Do not run mongo checks for old releases

    In Fuel releases before 6.1 we didn't have 'external mongo' feature,
    and therefore running mongo checks is invalid operation.

    Closes-Bug: #1463880

    Change-Id: I58dd0ebd6de610448bf297d0bd97c6a334f6abc0
    Signed-off-by: Igor Kalnitsky <email address hidden>

[Ihor Kalnytskyi (ikalnytskyi)]

I don't know why it's in Confirmed state. Both patches (original and backport) are in master. Move it to fix commited then.

[Maksym Strukov (unbelll)]

Verified as fixed in 7.0-262

{"build_id": "262", "build_number": "262", "release_versions": {"2015.1.0-7.0": {"VERSION": {"build_id": "262", "build_number": "262", "api": "1.0", "fuel-library_sha": "1556601b9b7503285714d7d1e02cc0807b1c68f0", "nailgun_sha": "b564ae20116297750bf6402b3a017e219bf4b468", "feature_groups": ["mirantis"], "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd", "openstack_version": "2015.1.0-7.0", "fuel-agent_sha": "082a47bf014002e515001be05f99040437281a2d", "production": "docker", "python-fuelclient_sha": "9643fa07f1290071511066804f962f62fe27b512", "astute_sha": "e63709d16bd4c1949bef820ac336c9393c040d25", "fuel-ostf_sha": "582a81ccaa1e439a3aec4b8b8f6994735de840f4", "release": "7.0", "fuelmain_sha": "4dc6799370da4cddf06c04e4ecb7646102298535"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "1556601b9b7503285714d7d1e02cc0807b1c68f0", "nailgun_sha": "b564ae20116297750bf6402b3a017e219bf4b468", "feature_groups": ["mirantis"], "fuel-nailgun-agent_sha": "d7027952870a35db8dc52f185bb1158cdd3d1ebd", "openstack_version": "2015.1.0-7.0", "fuel-agent_sha": "082a47bf014002e515001be05f99040437281a2d", "production": "docker", "python-fuelclient_sha": "9643fa07f1290071511066804f962f62fe27b512", "astute_sha": "e63709d16bd4c1949bef820ac336c9393c040d25", "fuel-ostf_sha": "582a81ccaa1e439a3aec4b8b8f6994735de840f4", "release": "7.0", "fuelmain_sha": "4dc6799370da4cddf06c04e4ecb7646102298535"}