Incorrect error message when creating env with invalid name

[Kirill Zaitsev]

Step to reproduce:
1. Navigate to Murano > Application Catalog > Environments
2. Click on 'Create Environment'
3. Enter invalid environment name "!@#$%%$$" and click on "Create"
4. Take a look at error message, it says that "Environment names must contain only alphanumeric or '_-.' characters and must start with alpha "
5. Enter "aaaaa_-." name and click on "Create"

Observed result:
"aaaa_-." name is invalid

[Lei Zhang (lei-a-zhang)]

hi, after checking source code I found the name validator is '^[a-zA-Z]+[\w-]*$', so I guess just fixing help text of the form is OK, no need to change the rule of environment name validation, right?

[Kirill Zaitsev (kzaitsev)]

You can do both, since you're making regex more permissive — there will be no invalid names in the db, so it's ok to do it both ways.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/199117

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/199117
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=52ec9285e60f488fb62291dc1ca6cb9f806f8708
Submitter: Jenkins
Branch: stable/kilo

commit 52ec9285e60f488fb62291dc1ca6cb9f806f8708
Author: leizhang <email address hidden>
Date: Fri Jun 26 21:08:12 2015 +0800

    Fix inconsistency of message and validation when create env(dashboard)

    If you create env with an invalid env name, the error message you get
    conflicts with the rule of validating env name, change the rule to
    adjust to the display message. Two validation rules need to be changed,
    one at murano api, the other at muranodashboard.

    Change-Id: Ib5a8a87cf295586214bced08c99a9e89ae1ee38f
    Closes-bug: #1463852

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.