OpenStack Dashboard (Horizon)

JSCS doesnt skip external libs

Bug #1463791 reported by Rob Cresswell on 2015-06-10

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	Medium	Unassigned	OpenStack Dashboard (Horizon) 8.0.0 "liberty"

JSCS currently doesn't skip external libs, and thus throws many errors that we cannot fix.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-06-10: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/190131

Changed in horizon:
assignee:	nobody → Rob Cresswell (robcresswell)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2015-06-11

Changed in horizon:
assignee:	Rob Cresswell (robcresswell) → Richard Jones (r1chardj0n3s)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-06-11: Fix merged to horizon (master)

commit fda1062195ecb0ff38d71cff8b2d3304043059c2
Author: Rob Cresswell <email address hidden>
Date: Wed Jun 10 12:29:23 2015 +0100

Extends .jscsrc to ignore 3rd party files

Adds a few files that should be skipped to the .jscsrc, since they are
beyond our control (external libs, generated coverage reports etc.)

This also reduces the error count to around 2k

Closes-Bug: 1463791
Change-Id: Iac87e41edd797c2a8318dcaceefe0651bd22dd61

Changed in horizon:
status:	In Progress → Fix Committed

Changed in horizon:
assignee:	Richard Jones (r1chardj0n3s) → Rob Cresswell (robcresswell)
milestone:	none → liberty-1
importance:	Undecided → Medium

Doug Hellmann (doug-hellmann) on 2015-06-23

Changed in horizon:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-10-15

Changed in horizon:
milestone:	liberty-1 → 8.0.0

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.