Agent object save method doesn't raise ValueError

[Rajesh Tailor]

ValueError exception is unnecessarily caught while saving agent object in
nova/api/openstack/compute/contrib/agent.py module.

[Matthew Gilliard (matthew-gilliard-u)]

This isn't a bug, and the proposed "fix" is in Nova, not Cinder.

[Markus Zoeller (markus_z) (mzoeller)]

@Rajesh Tailor (rajesh-tailor):

Could you please describe why you think that it should be changed? Matthew Gilliard seems to have doubts that this is a bug.

[Rajesh Tailor (rajesh-tailor)]

Hi Markus Zoeller,

The ValueError exception block should be removed because it is dead code.
There is no ValueError raised from either create or save method of agent object.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/190525
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=68c4e0aa27e36ec7331b773475407e0bff2d1d4c
Submitter: Jenkins
Branch: master

commit 68c4e0aa27e36ec7331b773475407e0bff2d1d4c
Author: Rajesh Tailor <email address hidden>
Date: Wed Jun 10 00:29:06 2015 -0700

    Remove unnecessary ValueError exception

    Agent object save method doesn't raise ValueError hence removed
    unnecessary ValueError exception block while calling Agent object
    save method.

    ApiImpact: 400 BadRequest response will be returned in case invalid
    agent id is provided during agent-delete, earlier it was returning
    500 InternalServerError response.

    Closes-Bug: 1463696
    Change-Id: I600e70aff2d271e22ccad3b0302fc45a942c98bb