LBaaS plugin can delegate VIP allocation to drivers

[Brandon Logan]

There are use cases where some drivers will want the responsibility of allocating the VIP of a load balancer. This will be further detailed in a spec.

[Doug Wiegley (dougwig)]

Flagging for driver discussion, due to the backend interchange issue.

[Kyle Mestery (mestery)]

I'm -1 to this, because this has the potential to expose details of the underlying implementation. We've generally kept to letting the users work with the logical networks, and this seems like it could let them move to understanding the implementation underneath. Am I missing something?

[Kyle Mestery (mestery)]

How are flavors causing the API to not be the same? Please explain.

[Doug Wiegley (dougwig)]

Brandon to write a spec with uses cases and specific examples.

[Stephen Balukoff (sbalukoff)]

Kyle: I realize that more than likely some discussion has happened on this bug outside of this bug report web page. As such: Do you still think this would potentially expose implementation details to the user? Given the intent of this feature to allow for slightly more advanced workflows when it comes to provisioning certain types of services (and that it's really the driver writers would would need to expose this kind of capability in order for Neutron to delegate responsibility for the same to them), it doesn't seem to me like the end-users would be exposed to anything more than now.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/197772
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=89d493d36a905f7eab371c3d4ab5a6b054e91fd6
Submitter: Jenkins
Branch: master

commit 89d493d36a905f7eab371c3d4ab5a6b054e91fd6
Author: Brandon Logan <email address hidden>
Date: Fri Jun 19 11:40:42 2015 -0500

    Vip delegation

    Change-Id: I902c42b56ff5bf86e042294cde6b933806e0303b
    Partial-Bug: 1463594

[Armando Migliaccio (armando-migliaccio)]

I see that code merged here, but it was a partial and the commit message was also an excellent example of how to write a good one. Can someone elaborate? I am lost.

[Brandon Logan (brandon-logan)]

Yeah that was a great commit message wasn't it? I'd say this is still pending because that review that merged just set up the plugin to allow a driver to do the vip delegation. I have a review in WIP that actually does it for Octavia, so since Octavia is the reference implementation now, I don't think this should be closed until that merges. I'll be sure to update the commit message to have Closes-Bug: directive on it (and also better commit message, sorry bout that).

[Armando Migliaccio (armando-migliaccio)]

So it is a feature that's been given the go ahead/approved? If not, you should really move it to in-progress. RFE bugs are taken care of by members of the drivers team.

[Armando Migliaccio (armando-migliaccio)]

should *not*

[Brandon Logan (brandon-logan)]

I didn't move it to in progress. I pushed a commit that referenced this and it automatically put it In Progress.

[Brandon Logan (brandon-logan)]

oh and it has been approved, sorry didn't mention that.

[Brandon Logan (brandon-logan)]

Before i stick my foot in my mouth further, I'm going to rescind that last comment and say I thought it was approved, because its possible my memory has failed me. It has before.

[Doug Wiegley (dougwig)]

Kyle, I don't think this leaks implementation, it just shifts where the neutron port is allocated (and potentially how an address is selected), but it's still just ports.

And it's optional.

[Armando Migliaccio (armando-migliaccio)]

Ack

[Armando Migliaccio (armando-migliaccio)]

Some work has already started.

Related blueprint connected below:

https://blueprints.launchpad.net/neutron/+spec/vip-delegation

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214058
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=e1a4969c87da55143ef3273141203789e2c91582
Submitter: Jenkins
Branch: master

commit e1a4969c87da55143ef3273141203789e2c91582
Author: Brandon Logan <email address hidden>
Date: Mon Aug 17 18:43:00 2015 -0500

    Add ability for octavia to allocate vip

    Adds a configuration option (defaults to False) to allow octavia to be
    responsible for allocating the VIP. If this is the case, then the driver will
    then update the neutron-lbaas load balancer database with the vip information.

    This satisfies a few use cases where a single port created by neutron lbaas
    on behalf of the user is too restrictive for more complex vip allocation needs
    that Octavia does and will support.

    Closes-Bug: #1463594
    Change-Id: Idd52d5d8325f1447aadcdf9c687ce010a6488cf6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/192958
Committed: https://git.openstack.org/cgit/openstack/neutron-specs/commit/?id=dbaeb238f616b44bf72aea6e7677e88ac255144b
Submitter: Jenkins
Branch: master

commit dbaeb238f616b44bf72aea6e7677e88ac255144b
Author: Brandon Logan <email address hidden>
Date: Wed Jun 17 22:37:16 2015 -0500

    Allow lbaas drivers the option to allocate VIPs

    Partial-Bug: #1463594

    Change-Id: Ifba47b0d2124ae5ede17adf1c64d9f7a95f4db04

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-lbaas 8.0.0.0b1 development milestone.