ACQ distribution formula PCRUD perms too strict, affects batch update

[Bill Erickson]

Confirmed in Evergreen 2.8 and 2.5, likely affects all versions.

The PCRUD <retrieve> permission for distribution formulas (acq.distribution_formula) requires that staff creating purchase orders via the PO batch update bar (along the top of the PO page) using distribution formulas must have the ADMIN_ACQ_DISTRIB_FORMULA permission. This should be downgraded to CREATE_PURCHASE_ORDER so regular ACQ order staff can use them. Write operations should remain as-is.

Patch en route.

[Bill Erickson (berick)]

Correction: The perm should not be downgrade, but augmented with the additional CREATE_PURCHASE_ORDER permission.

[Bill Erickson (berick)]

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1463590-dist-form-pcrud-read-perms

[Bill Erickson (berick)]

Test plan:

1. Create at least one distribution formula w/ entries with an administrative account in the staff client then log out.
2. Login with an "Acquisitions" user (profile=6) to the staff client (e.g. br1mroberts in concerto)
3. Create a new purchase order or load a pending (pre-activated) purchase order for the same location at which the distribution formula exists.
4. The Distribution Formula selector in the batch update bar will be empty prior to applying this patch. With the patch, the formula will appear.

[Ben Shum (bshum)]

Picked to master and backported to rel_2_8 and rel_2_7. Thanks Bill, seems sane to me.