Juniper Openstack

Calls to Node/LinkTableExport() from the exporter must pass the right partition

Bug #1463204 reported by Tapan Karwa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.0
Fix Committed
Medium
Tapan Karwa
Juniper Openstack r2.02
R2.1
Fix Committed
Medium
Tapan Karwa
Juniper Openstack r2.11 "r2.11"
R2.20
Fix Committed
Medium
Tapan Karwa
Juniper Openstack r2.20-fcs
Trunk
Fix Committed
Medium
Tapan Karwa
Juniper Openstack r3.0-fcs

Bug Description

1)
In our current code base, we can have the following code flow:

LinkTableExport() --> ProcessAdjacentNode() --> NodeTableExport()

LinkTableExport(DBTablePartBase *partition,
---> ProcessAdjacentNode(DBTablePartBase *partition, IFMapNode *node, …….
---> NodeTableExport(DBTablePartBase *partition,

The partition in all the 3 cases is the one that sits in the link-table.
But, NodeTableExport should get the node's table's partition, not the link-table's partition.

2)
We also have the following code flow:

NodeTableExport(DBTablePartBase *partition,
---> RemoveDependentLinks(DBTablePartBase *partition,
---> LinkTableExport(DBTablePartBase *partition,

The partition in all the 3 cases is the one that sits in the node's table.
But, LinkTableExport should get the ifmap-link-table's partition.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/11392
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/11394
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.1

Review in progress for https://review.opencontrail.org/11395
Submitter: Tapan Karwa (<email address hidden>)

Nischal Sheth (nsheth)
tags: added: contrail-control
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11392
Committed: http://github.org/Juniper/contrail-controller/commit/88a7270ad9e732dc92f7f42697447112dec21859
Submitter: Zuul
Branch: R2.20

commit 88a7270ad9e732dc92f7f42697447112dec21859
Author: Tapan Karwa <email address hidden>
Date: Mon Jun 8 16:37:04 2015 -0700

Calls to Node/LinkTableExport() from the exporter must pass the right partition

Change-Id: Ibac50e27dd01b1cdf521ae86227f63b3c919411a
Closes-Bug:1463204

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.0

Review in progress for https://review.opencontrail.org/11418
Submitter: Tapan Karwa (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11394
Committed: http://github.org/Juniper/contrail-controller/commit/3f6fcd4d11ba77e8811091a149c397d545562656
Submitter: Zuul
Branch: master

commit 3f6fcd4d11ba77e8811091a149c397d545562656
Author: Tapan Karwa <email address hidden>
Date: Mon Jun 8 16:37:04 2015 -0700

Calls to Node/LinkTableExport() from the exporter must pass the right partition

Change-Id: Ibac50e27dd01b1cdf521ae86227f63b3c919411a
Closes-Bug:1463204

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11395
Committed: http://github.org/Juniper/contrail-controller/commit/904f37548f3a8a0bb08579f74259e574a80243a4
Submitter: Zuul
Branch: R2.1

commit 904f37548f3a8a0bb08579f74259e574a80243a4
Author: Tapan Karwa <email address hidden>
Date: Mon Jun 8 16:37:04 2015 -0700

Calls to Node/LinkTableExport() from the exporter must pass
the right partition

Change-Id: Ibac50e27dd01b1cdf521ae86227f63b3c919411a
Closes-Bug:1463204

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11418
Committed: http://github.org/Juniper/contrail-controller/commit/78afcf493357db70a91af8a3130a381ea7fd242f
Submitter: Zuul
Branch: R2.0

commit 78afcf493357db70a91af8a3130a381ea7fd242f
Author: Tapan Karwa <email address hidden>
Date: Mon Jun 8 16:37:04 2015 -0700

Calls to Node/LinkTableExport() from the exporter must pass the right partition

Change-Id: Ibac50e27dd01b1cdf521ae86227f63b3c919411a
Closes-Bug:1463204

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.