Clean up ProductSeries naming properties

[David Allouche]

The ProductSeries class (Release series in the user interface) currently provides a number of methods for name display.

displayname = name
title = "%s Series: %s" % (product.displayname, series.displayname)
bugtargetdisplayname = "%s %s" % (product.displayname, series.name)
bugtargetname = "%s/%s" % (product.name, series.name)

 * displayname is not a useful way to refer to a series, it does not provide enough context because it does not include the product name.
 * title is not generally useful because of this weird "Series: " in the middle.
 * bugtargetdisplayname is really most generally useful display name.
 * bugtargetname is the real unique name for the productseries.

The standard displayname and title properties should be modified to be more useful, and the bugtarget properties should be renamed to reflect their general usefulness.

[David Allouche (ddaa)]

 ddaa: actually, I'd like bugtargetname to be renamed to "unique_name" (for consistency with Branch.unique_name), and bugtargetdisplayname to replace the existing displayname.
 sabdfl: ddaa: +1 on changing ProductSeries.displayname to be more like this:
 sabdfl: firefox "trunk" series
 sabdfl: hmm.. perhaps that should be .title
 sabdfl: and displayname should just be "firefox trunk"
 ddaa: sabdfl: you mean
 ddaa: * series.title = smartquote('%s "%s" series') % (product.displayname, series.name)
 ddaa: * series.displayname = "%s %s" % (product.displayname, series.name)
 ddaa: Right?

In summary:
 * series.title = smartquote('%s "%s" series') % (product.displayname, series.name)
 * series.displayname = "%s %s" % (product.displayname, series.name)
 * series.unique_name = %s/%s" % (product.name, series.name)
 * remove bugtargetdisplayname
 * remove bugtargetname

[Matthew Paul Thomas (mpt)]

ddaa asked me to record my approval of this in a comment. I approve, as long as it does not change the resulting text in bug notifications (and it seems it won't).

[Björn Tillenius (bjornt)]

I more or less agree with the changes proposed here. Two things to note, though:

  1) IDistroSeries should be modified in the same way.
  2) You can't just drop bugtargetname and bugtargetdisplayname;
      they are part of IBugTarget, so you'd have to make this
      change across all IBugTargets.

Since the second point is quite a big one, I'd propose keeping those attributes, delegating to unique_name and displayname.

[David Allouche (ddaa)]

Assigning to self. Medium importance. Targeting for 1.1.10. In progress.

[David Allouche (ddaa)]

Note: I am only fixing ProductSeries. Without touching DistroSeries (which has a different set of naming attributes), and without touching IBugTarget interface (making bugtargetdisplayname and bugtargetname delegate to displayname and unique_name in ProductSeries).

[David Allouche (ddaa)]

Resolution currently blocked on bug 69988,

[David Allouche (ddaa)]

Blocker bug 69988 was targeted to 1.1.11, so retarting this to 1.1.11.