VMware: stable icehouse unable to spawn VM

[Gary Kotton]

Unable to boot VM due to patch
https://github.com/openstack/nova/commit/539d632fdea1696dc74fd2fb05921466f804e19e

This is with VC 6.

The reason is:
nova-scheduler.log.1:2015-06-02 16:01:49.280 1174 ERROR nova.scheduler.filter_scheduler [req-18c26579-09e7-4287-b401-27ac3505e7c3 bf28f7d47bf348d6ab6bcf31f0f96c92 04ad461fb68d4b80b2911b3fe0f6b1f9] [instance: 5b3cca48-a295-4aa0-9176-798c174aeb3f] Error from last host: icehouse (node domain-c9(compute)): [u'Traceback (most recent call last):\n', u' File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 1379, in _build_instance\n set_access_ip=set_access_ip)\n', u' File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 410, in decorated_function\n return function(self, context, *args, **kwargs)\n', u' File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 1797, in _spawn\n LOG.exception(_(\'Instance failed to spawn\'), instance=instance)\n', u' File "/usr/lib/python2.7/dist-packages/nova/openstack/common/excutils.py", line 68, in __exit__\n six.reraise(self.type_, self.value, self.tb)\n', u' File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 1794, in _spawn\n block_device_info)\n', u' File "/usr/lib/python2.7/dist-packages/nova/virt/vmwareapi/driver.py", line 629, in spawn\n admin_password, network_info, block_device_info)\n', u' File "/usr/lib/python2.7/dist-packages/nova/virt/vmwareapi/vmops.py", line 689, in spawn\n _power_on_vm()\n', u' File "/usr/lib/python2.7/dist-packages/nova/virt/vmwareapi/vmops.py", line 685, in _power_on_vm\n self._session._wait_for_task(power_on_task)\n', u' File "/usr/lib/python2.7/dist-packages/nova/virt/vmwareapi/driver.py", line 966, in _wait_for_task\n ret_val = done.wait()\n', u' File "/usr/lib/python2.7/dist-packages/eventlet/event.py", line 116, in wait\n return hubs.get_hub().switch()\n', u' File "/usr/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 187, in switch\n return self.greenlet.switch()\n', u"AttributeError: TaskInfo instance has no attribute 'name'\n"]

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/188830

[John Garbutt (johngarbutt)]

This is high, because it does not affect *every* user

[Alan Pevec (apevec)]

> Unable to boot VM due to patch https://github.com/openstack/nova/commit/539d632fdea1696dc74fd2fb05921466f804e19e

But this is Havana commit?
How was this fixed in >= Juno ?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/188830
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a83eb5fcdcfbd6a7896cda66e279696a1191e490
Submitter: Jenkins
Branch: stable/icehouse

commit a83eb5fcdcfbd6a7896cda66e279696a1191e490
Author: Gary Kotton <email address hidden>
Date: Fri Jun 5 08:41:12 2015 -0700

    VMware: fix AttributeError: TaskInfo instance has no attribute 'name'

    This happens in stable/icehouse with vCenter 6. This is a
    stable/icehouse only change since this code was moved to oslo.vmware
    and in Juno Nova was using this code from oslo.vwmware.

    Furthermore, the _poll_task code in oslo.vmware was taken from cinder
    which didn't have the call on task_info.name so the bug isn't there.

    Change-Id: I729f1cdca1d4e02e31f26aa0e170c30be1a65288
    Closes-bug: #1462424