Mirantis OpenStack

python-xstatic-magic-search: package re-embedds javascript

Bug #1462274 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
Daniil Trishkin
Mirantis OpenStack 8.0
7.0.x
Won't Fix
Medium
Daniil Trishkin
8.0.x
Fix Released
Medium
Daniil Trishkin
Mirantis OpenStack 8.0

Bug Description

In Debian, the package has a patch to remove the embedded javascript form the final result of the package. But in Ubuntu, that patch is gone.

We should:

1- Package libjs-magic-search (it's available from Sid)

2- Reimport the package from Sid, or add the patch that was there before Ubuntu guys removed it

Also, please make sure to keep old debian/changelog entries. Removing them helps nobody, as we loose the history on the package, and it is harder to know what has been done.

Vasyl Saienko (vsaienko)
Changed in mos:
importance: Undecided → Medium
milestone: none → 7.0
status: New → Confirmed
assignee: nobody → Vasyl Saienko (vsaienko)
Vasyl Saienko (vsaienko)
Changed in mos:
assignee: Vasyl Saienko (vsaienko) → MOS Packaging Team (mos-packaging)
Revision history for this message
Daniil Trishkin (dtrishkin) wrote :

Fix - https://review.fuel-infra.org/#/c/9197/

Changed in mos:
assignee: MOS Packaging Team (mos-packaging) → Daniil Trishkin (dtrishkin)
status: Confirmed → Fix Committed
Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Having a look at the code, the debianize.patch file isn't present in debian/patches, so therefore, the package is still using the embedded version of magic_search.js / magic_search.scss from XStatic, instead of using the libjs-magic-search content, which is weird because the package still depends on the libjs package.

However, it has been fixed in the 8.0 branch (ie: it contains and uses the debianize.patch).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.