backup driver can save inefficiently compressed chunks

Bug #1462268 reported by Tom Barron
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Tom Barron

Bug Description

With the "chunked" backup drivers (currently Swift and NFS), we save backup chunks even when the compressed length is not a gain over the original, uncompressed length.

With incremental backups, where chunks can be built from short "extents", the likelihood of this situation has significantly increased.

Tom Barron (tpb)
Changed in cinder:
assignee: nobody → Tom Barron (tpb)
status: New → In Progress
Xing Yang (xing-yang)
Changed in cinder:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/188591
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=fc5affbe757099011481678e74e0f19d5200424d
Submitter: Jenkins
Branch: master

commit fc5affbe757099011481678e74e0f19d5200424d
Author: Tom Barron <email address hidden>
Date: Thu May 7 15:46:06 2015 -0400

    Handle ineffective backup compression

    Don't compress chunks when compressed length is not a gain over
    original, uncompressed length.

    With incremental backups, where chunks can be built from short
    "extents", the likelihood of this situation has significantly
    increased.

    Closes-Bug: 1462268
    Change-Id: Id960cb22ae74f19154f49a0c19ee07a00145067f

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.