oslo.config: package improvement

[Thomas Goirand]

This is a general review of the package

debian/copyright
----------------
- only includes myself (ie: <email address hidden>), it should also show some Mirantis contribs

General
-------
- Why dropping python3 support? That's useless effort for not valid reason
- Package is not running unit tests. These are *VERY* important, please restore them.

debian/patches
--------------
- All patches are desactivated, first: why? Second: why do we have a patches folder at all if it's not in use?
- It's missing Debian's do-not-run-toplevel-tests.patch needed for Python3 testing (limits to non-namespace tests)

debian/control
--------------
- missing build-depends: python-sphinx, dh-python. python-pbr should be >= 0.8 and not >= 0.10
- missing depends: python-stevedore

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/9888
Submitter: Dmitry Teselkin <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: 7e2cf928f206af91dfa7ba155153b2ed2ebe7169
Author: Mikhail Ivanov <email address hidden>
Date: Tue Jul 28 11:18:50 2015

Oslo.config package improvements

  * remove unnecessary patch for docs
  * Add python3 packages
  * add missing build-depends

Closes-Bug: #1462254
Change-Id: I0bf6f6c5bf88c1273d0946cf7cf6218d09a34dfb

[Timur Nurlygayanov (tnurlygayanov)]

Looks like this fix was not merged for MOS 7.0:

I can see on MOS 7.0 ISO #265:
cat /usr/share/doc/python-json-patch/copyright
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: python-json-patch
Source: git://github.com/stefankoegl/python-json-patch.git

Files: debian/*
Copyright: (c) 2012, Thomas Goirand <email address hidden>
License: BSD-3-clauses

Files: *
Copyright: 2012, Stefan Kögl <email address hidden>
License: BSD-3-clauses

License: BSD-3-clauses
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions are met:
 .
 1. Redistributions of source code must retain the above copyright
 notice, this list of conditions and the following disclaimer.
 .
 2. Redistributions in binary form must reproduce the above copyright notice,
 this list of conditions and the following disclaimer in the documentation
 and/or other materials provided with the distribution.
 .
 3. The name of the author may not be used to endorse or promote products
 derived from this software without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE AUTHOR "AS IS" AND ANY EXPRESS OR IMPLIED
 WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
 MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
 EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
 PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
 OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
 WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
 OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
 OF THE POSSIBILITY OF SUCH DAMAGE.
root@node-1:/var/log#

[Timur Nurlygayanov (tnurlygayanov)]

Fix verified on MOS 7.0 ISO #265:

root@node-1:/var/log# dpkg --status python-oslo.config
Package: python-oslo.config
Status: install ok installed
Priority: optional
Section: python
Installed-Size: 401
Maintainer: MOS Oslo Team <email address hidden>
Architecture: all
Source: oslo-config
Version: 1:1.9.3-1~u14.04+mos304
Depends: python-netaddr (>= 0.7.12), python-six (>= 1.9.0), python-stevedore (>= 1.1.0), python:any (>= 2.7.5-5~), python:any (<< 2.8), python-pbr, python2.7
Description: Common code for Openstack Projects (configuration API) - Python 2.x
 The OpenStack Oslo project provides Python libraries containing
 infrastructure code shared by OpenStack projects.
 .
 The OpenStack Oslo Configuration API supports parsing command line
 arguments and .ini style configuration files.
 .
 This package provides the Python 2.x module.
Homepage: https://github.com/openstack/oslo-incubator
Original-Maintainer: PKG OpenStack <email address hidden>
root@node-1:/var/log# cat /usr/lib/python2.7/dist-packages/oslo_config/cfg^C
root@node-1:/var/log# cat /usr/share/doc/python-oslo.config/copyright
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Upstream-Name: python-json-patch
Source: git://github.com/openstack/oslo-config.git

Files: debian/*
Copyright: (c) 2012, Thomas Goirand <email address hidden>
           (c) 2014, Denis Egorenko <email address hidden>
           (c) 2015, Vasyl Saienko <email address hidden>
           (c) 2015, Mikhail Ivanov <email address hidden>