Keystone: package improvement

Bug #1462252 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
Mikhail Ivanov

Bug Description

This is a general review of the package

debian/copyright:
-----------------
- Lack of debian/* entry
- Wrong format spec (should be: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/)

debian/clean:
-------------
- same file twice

debian/control:
---------------
- Everything in build-depends. Lots should go in build-depends-indep
- lack of python-ldappool build-depends
- Missing build-depends: dh-python, python-pysqlite2, python-tempest-lib
- Missing build-depends-indep: python-dogpile.cache, python-oslo.log
- Wrong version for python-eventlet (should be 0.16.1 not 0.16)
- Useless build-depends: python-pecan,
- Useless depends: python-lxml, python-pam, python-sqlparse,

debian/rules:
-------------
- sphinx doc should be done in override_dh_auto_build:, no --with sphinxdoc, adding bad libjs-jquery with no replacement of the embedded jquery, no ${sphinxdoc:Depends} depends:

debian/keystone.dirs
--------------------
- Please remove this file. /etc/keystone is already addressed by the keystone.install, other folders should be created in postinst, pureged in postrm

debian/keystone.upstart
-----------------------
- No check if the binary is present
- no respawn limit
- no chgid

By the way:
- No support for sysv-rc or systemd

Advise: switch to openstack-pkg-tools generated init scripts

debian/keystone.preinst
-----------------------
- Bad chown keystone:keystone -R /etc/keystone which is forbidden by policy if the folder is in the package

ruhe (ruhe)
Changed in mos:
milestone: none → 7.0
assignee: nobody → MOS Deployment Team (mos-deployment)
importance: Undecided → Medium
Changed in mos:
status: New → Confirmed
Changed in mos:
assignee: MOS Deployment Team (mos-deployment) → MOS Packaging Team (mos-packaging)
Mikhail Ivanov (mivanov)
Changed in mos:
assignee: MOS Packaging Team (mos-packaging) → Mikhail Ivanov (mivanov)
status: Confirmed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack-build/keystone-build (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/9840
Submitter: Ivan Udovichenko <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: 02dc68208d77a8d1b9082c4622bf1908b23583ce
Author: Mikhail Ivanov <email address hidden>
Date: Thu Aug 6 08:34:01 2015

Improve Keystone packages

- fix build and runtime dependencies
- fix files installation

Closes-Bug: #1462252

Change-Id: Ie870a04f369ea0ed26d204fc4f86637b68c71b5e

Mikhail Ivanov (mivanov)
Changed in mos:
status: In Progress → Fix Committed
Revision history for this message
Timur Nurlygayanov (tnurlygayanov) wrote :

Fix verified on MOS 7.0 ISO #288 RC2.

Changed in mos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.