Neutron: package improvement

Bug #1462251 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
Sergey Kolekonov

Bug Description

This is a general review of the package.

debian/control
--------------
- Missing build-depends: dh-python, dh-systemd, openstack-pkg-tools (>= 23~), python-pbr, python-setuptools, python-sphinx
- Missing build-depends-indep: python-pyudev, subunit
- Useless build-depends-indep: python-anyjson, python-babel, python-iso8601, python-simplejson, python-subunit, python-webtest, python-unittest2, testrepository,
- Missing dependency: iproute2, ipset, python-gflags, python-mysqldb, python-psycopg2, python-pyudev
- Useless depends: python-anyjson, python-babel, python-kombu
- Useless: XS-Python-Version: >= 2.7
- conntrack dependency missplaced (should be in neutron-common)
- Why is neutron-common depending on python-neutron-fwaas?

debian/copyright:
-----------------
- No mention of the licensing for debian/*

debian/changelog:
-----------------
- only 2 entries!

debian/neutron-common.dirs
--------------------------
- Same as for other packages: lots (if not all) of this file should go away.

debian/*.logrotate
------------------
- Advise: scrap all of these, and use a single neutron-commonl.logrotate using /var/log/neutron/*.log.
- Not using copytruncate: bad for production

plugin configuration
--------------------
- In Debian, the startup scripts are looking at the core_plugin values.
We should move to that, and scrap the /etc/default/neutron-server

debian/*.install
----------------
- Advise: scap all this, and install all in neutron-common. It's prone to lots of errors.

init scripts
------------
- Only support for upstart
- Missing chgid on all daemons
- neutron-plugin-mlnx-agent.upstart is doing chown neutron:root /var/run/neutron and that folder should be gid neutron
- lack of consistency for log files (ie: missing neutron- before <something.log>

naming conventions:
-------------------
- In Debian, we removed "plugin" from the name of the neutron-plugin-openvswitch-agent. I'd advise to do the same.

General:
--------
- All of these plugin packages are an invention of Canonical. I'd advise to scrap all of it, and switch to a more simple way: put everything in neutron-common, available all the time.

Tags: neutron
ruhe (ruhe)
Changed in mos:
milestone: none → 7.0
assignee: nobody → MOS Deployment Team (mos-deployment)
importance: Undecided → Medium
Changed in mos:
status: New → Confirmed
Changed in mos:
assignee: MOS Deployment Team (mos-deployment) → Sergey Kolekonov (skolekonov)
tags: added: neutron
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to openstack-build/neutron-build (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/9526
Submitter: Igor Yozhikov <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: a2762ccf67e2d52ccf212495c35a0640c2563bdb
Author: Sergey Kolekonov <email address hidden>
Date: Fri Jul 17 15:42:12 2015

Improve Neutron packages

- fix build and runtime dependencies
- fix a problem with Mellanox agent upstart script
- use universal logrotate configuration
- use chgid on all daemons

Related-bug: #1462251
Change-Id: I44bc699a9a6ac379b83b6f9e5d3676c256d587e7

Changed in mos:
status: Confirmed → Fix Committed
Anna Babich (ababich)
tags: added: on-verification
Anna Babich (ababich)
tags: removed: on-verification
Changed in mos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.