Horizon: package improvement

Bug #1462250 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Medium
Ivan Udovichenko

Bug Description

This is a general review of the package.

- Unit tests not done at all at build time.
- Package is running "collectstatic" which isn't useful, and even potentially dangerous. Instead, everything should simply be using the xstatic packages.

debian/pydist-overrides
-----------------------
- This file should really contain equivalent packages, not just remove dependencies.

debian/copyright:
-----------------
- Missing entries for debian/* files
- Missing entries for debian/static/* files

debian/changelog:
-----------------
- Missing past Ubuntu entries

General issues:
---------------
- No compile of gettext messages: no translation therefore?

- Dangerous deletion of UID / GID on purge

- Package contains already compiled javascripts in debian/static/openstack-dashboard/js/*. This is dangerous in case of security problems with .js thirdparty libs, and that's also almost certainly a license violation. I can see code from the d3 lib for example.

debian/control:
---------------
- Why build-depends on nose and others if unit tests aren't even run?
- Useless Depends: python-lockfile

ruhe (ruhe)
Changed in mos:
milestone: none → 7.0
assignee: nobody → MOS Deployment Team (mos-deployment)
importance: Undecided → Medium
Changed in mos:
status: New → Confirmed
ruhe (ruhe)
Changed in mos:
assignee: MOS Deployment Team (mos-deployment) → MOS Packaging Team (mos-packaging)
Changed in mos:
assignee: MOS Packaging Team (mos-packaging) → Ivan Udovichenko (iudovichenko)
status: Confirmed → In Progress
Changed in mos:
milestone: 7.0 → 8.0
Revision history for this message
Ivan Udovichenko (iudovichenko) wrote :

Switched to Debian source packages which already has provided changes.

Changed in mos:
status: In Progress → Fix Committed
Changed in mos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.