Cinder: package improvement

[Thomas Goirand]

This is a general review of the package.

d/changelog:
------------
- Missing old Ubuntu entries.

d/copyright:
------------
- Missing entries for the debian folder. My name isn't there, but it's in
some of the files in debian/* (like the init files...)

d/*.install:
------------
- Files spread on all packages.

d/cinder-common.dirs:
---------------------
- Again, definitions of folders who shouldn't be there

d/control:
----------
- Missing dh-python, python-sphinx, python-setuptools, python-pbr build-depends
- The above are in build-depends-indep (but they are needed in clean...)
- Useless versions for many packages (python-babel, python-coverage, etc.)
- Useless python-subunit build-depends-indep, missing subunit b-dep-i
- Useless python-lockfile depends
- My opinion: things in suggests: should be in depends: (it's cheap...)

d/cinder.conf:
--------------
- Why this file at all? Cinder uses a generated config file.

d/rules:
--------
- It's not generating cinder.conf dynamically. In Debian, I use:
        oslo-config-generator --output-file $(CURDIR)/etc/cinder/cinder.conf.sample \
                --wrap-width 140 \
                --namespace cinder \
                --namespace oslo.concurrency \
                --namespace oslo.db \
                --namespace oslo.messaging \
                --namespace oslo.policy \
                --namespace keystonemiddleware.auth_token \
                --namespace cinder.openstack.common.eventlet_backdoor \
                --namespace cinder.openstack.common.log \
                --namespace cinder.openstack.common.periodic_task \
                --namespace cinder.openstack.common.policy \
                --namespace oslo_db.concurrency

Should we use /usr/sbin/nologin instead of false as shell?

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Mikhail Ivanov <email address hidden>
Review: https://review.fuel-infra.org/10061

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/10061
Submitter: Igor Yozhikov <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: eff5d7b1796a0f3b15c69cbf47b9707687c8e48a
Author: Mikhail Ivanov <email address hidden>
Date: Wed Aug 5 17:23:11 2015

Improve cinder packages

  * Fix build and runtime dependencies
  * Fix files installation

Change-Id: If354bb8036bb9f703341f8d659014b970e95d6ed
Closes-Bug: #1462246

[Timur Nurlygayanov (tnurlygayanov)]

Fix verified on MOS 7.0 ISO #288 RC2.