Thumbnailer

vs-thumb hangs until we time it out for empty file

Bug #1462204 reported by Michi Henning
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GStreamer
Fix Released
Medium
Thumbnailer
Fix Released
Undecided
Michi Henning

Bug Description

When using thumbnailer-admin to create a thumbnail from an empty file called "empty", vs-thumb gets stuck. We eventually time it out and recover, but it would be nice if it realised that this isn't going to work more quickly.

Related branches

lp:~michihenning/thumbnailer/clear-cache-cmd
James Henstridge: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 881 lines (+617/-23)
16 files modified
include/internal/thumbnailer.h (+8/-0)
src/service/CMakeLists.txt (+1/-0)
src/service/admininterface.cpp (+24/-0)
src/service/admininterface.h (+2/-0)
src/service/admininterface.xml (+12/-0)
src/service/dbusinterface.cpp (+27/-8)
src/service/handler.cpp (+9/-2)
src/thumbnailer-admin/CMakeLists.txt (+3/-1)
src/thumbnailer-admin/clear.cpp (+99/-0)
src/thumbnailer-admin/clear.h (+51/-0)
src/thumbnailer-admin/show_stats.cpp (+2/-2)
src/thumbnailer-admin/thumbnailer-admin.cpp (+8/-5)
src/thumbnailer.cpp (+39/-0)
src/videoscreenshotter.cpp (+20/-0)
tests/thumbnailer-admin/thumbnailer-admin_test.cpp (+175/-5)
tests/thumbnailer/thumbnailer_test.cpp (+137/-0)
Revision history for this message
James Henstridge (jamesh) wrote :

As noted in the linked GStreamer bug I created, this seems to be a problem related to the fdsrc element (or its interaction with playbin).

Bug Watch Updater (bug-watch-updater)
Changed in gstreamer:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
James Henstridge (jamesh) wrote :

And now it's been marked fixed:

http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=91f537edf2946cbb5085782693b6c5111333db5f

We should probably work around the problem by erroring early on empty files.

Revision history for this message
Michi Henning (michihenning) wrote :

That was bloody quick!

Still, we need to work around it ourselves. It'll probably be months before this makes it into the archives.

Michi Henning (michihenning)
Changed in thumbnailer:
assignee: nobody → Michi Henning (michihenning)
status: New → In Progress
Bug Watch Updater (bug-watch-updater)
Changed in gstreamer:
status: Confirmed → Fix Released
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:thumbnailer/devel at revision 201, scheduled for release in thumbnailer, milestone Unknown

Changed in thumbnailer:
status: In Progress → Fix Committed
Michi Henning (michihenning)
Changed in thumbnailer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.