smart_add uses _get_inventory, _write_inventory, but should not
Bug #146165 reported by
Martin Pool
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
smart add should work directly on the working tree api, rather than converting to and from Inventory objects. This would probably be substantially faster for dirstate trees, would fix the underlying cause of some bugs in add, and would be a step towards deprecating paths that deal with whole inventories.
Related branches
lp:~jelmer/bzr/smart-add-invdelta
- Vincent Ladeuil: Needs Information
-
Diff: 766 lines (+268/-306)4 files modifiedbzrlib/add.py (+9/-6)
bzrlib/mutabletree.py (+253/-296)
bzrlib/tests/test_smart_add.py (+3/-4)
doc/en/release-notes/bzr-2.4.txt (+3/-0)
Changed in bzr: | |
status: | Triaged → Confirmed |
description: | updated |
Changed in bzr: | |
status: | Confirmed → In Progress |
tags: | added: add inventory tech-debt |
tags: | added: foreign |
summary: |
- add uses _get_inventory, _write_inventory, but should not + smart_add uses _get_inventory, _write_inventory, but should not |
Changed in bzr: | |
status: | Confirmed → In Progress |
Changed in bzr: | |
status: | In Progress → Fix Released |
milestone: | none → 2.4b4 |
To post a comment you must log in.
See also bug 146176