[Murano] environment is being deleted even though en error ocurred

[Kirill Zaitsev]

To reproduce:

1) create an env
2) add an app to the env
3) deploy the env
4) delete the package, containing the app
5) delete the env

Environment deletion should fail, but it doesn't. The env get's deleted, but destroy methods and heat stack is not deleted

Expected behaviour: Environment enter state: Delete Failure.

This behaviour was supposedly introduced by https://review.openstack.org/#/c/179533/ commit

https://bugs.launchpad.net/murano/+bug/1456724

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.1/2014.2
Change author: Kirill Zaitsev <email address hidden>
Review: https://review.fuel-infra.org/7528

[Kirill Zaitsev (kzaitsev)]

Release notes:

Sometimes env deletion can raise error.

There are two known scenarios, when this can occur:
1) If an application uses classes, that define destroy() method; in case destroy() raises an exception env deletion would fail. (currently this can happen with kubernetes application from app catalog, after a failed deploy. Although the app is scheduled to be fixed.)
2) If an application, that was deployed was removed from murano Application Catalog (e.g. deleted from Package Definitions page) env deletion would.

In both of the cases murano would actually delete the environment, but would not delete the heat stack.

There is currently no mitigation technique or workaround available for the bug. User would have to navigate to Orchestration -> Stacks and delete any leftover stacks manually.

[Ekaterina Chernova (efedorova)]

For 7.0 this functionality should be backported from liberty

[Ekaterina Chernova (efedorova)]

This is not fixed in upstream yet

[Kirill Zaitsev (kzaitsev)]

Bug is in progress, would be fixed before SCF

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Kirill Zaitsev <email address hidden>
Review: https://review.fuel-infra.org/10064

[Fuel Devops McRobotson (fuel-devops-robot)]

Related fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Nikolay Starodubtsev <email address hidden>
Review: https://review.fuel-infra.org/10065

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Kirill Zaitsev <email address hidden> on branch: openstack-ci/fuel-6.1/2014.2
Review: https://review.fuel-infra.org/7528

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/10064
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: a0ad16a7521d800cb6fed4a11c8d4a44ff9993c3
Author: Kirill Zaitsev <email address hidden>
Date: Tue Aug 4 10:27:02 2015

Include original ObjectsCopy/Attributes in exception_result

Before if an exception occured during dsl cleanup exception_result would
use empty ObjectsCopy and empty Attributes for result. In case exception
happened during env deletion this would cause env to be deleted by API,
because it ignored isException and treated any result as valid.

Now exception_result also includes original ObjectsCopy/Attributes in case
they're empty in exception_result.
Api not only checks count of 'error' statuses, in session, but also
checks isException attribute of the result, and treats exception results
as Errors, therefore marking deployment/deletion as failed.

Logging of results in API is now aware, that objects can be empty during
app deletion and no longer throws AttributeError because of that.

Change-Id: Idec8191ee25d1cac606741673719bbb8a72709b0
Closes-Bug: #1461594
(cherry picked from commit 1e62fafe8212a1e2eb4d5f2bad3da2d8c88a33fe)

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/10065
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: eed9f3fd3a32b5fddfa31f1d0929101e0ae74080
Author: Nikolay Starodubtsev <email address hidden>
Date: Tue Aug 4 10:27:02 2015

Add possibilty to delete environment with incorrect .destroy method

In this patch we introduce a possibility to delete an environment
which contains a package with incorrect .destroy method. Previously
such kind of environment was stucked in 'Deletion failure' status
and we can't do anything with that, now murano environment and heat
stack will be deleted completely.

Related-Bug: #1461594
Change-Id: I90dfa4e6e30c325a17e746c36a4e467189834294

[Alexander Bochkarev (abochkarev)]

Verified with fuel-7.0-241-2015-08-27_03-02-45.iso