Still receive group messages after turn off Group messages notification

Bug #1461331 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Cecilia Vela Gurovic

Bug Description

Version: master(15.10), 15.04, 1.10

I still receive group messages after turn off Group messages notification

Steps:
1. Login as userA, in user setting page, set notification "Group messages" to "None".
2. Create a group with membership request is ON.
3. Login as another userB, send a request to join the group

Login as userA, open the inbox, you still see the group membership request from userB

Tags: bite-sized
Revision history for this message
Son Nguyen (ngson2000) wrote :

When an user send a request to join a group, a new message is created and send to the group admins.

This message is incorrectly classified as 'maharamessage' in line 83, group/requestjoin.php. It should be 'groupmessage'.

tags: added: bite-sized
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6949

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6949
Committed: https://git.mahara.org/mahara/mahara/commit/b235a10ad647b566f0af29afef06670637aca564
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b235a10ad647b566f0af29afef06670637aca564
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Sep 9 12:56:39 2016 +1200

Bug 1461331: Correctly classified notifications as groupmessage
behatnotneeded

Change-Id: I90976793872d761727b75fb9692425f1d1ac5eea

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 16.10.0
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/6963

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6963
Committed: https://git.mahara.org/mahara/mahara/commit/176570b664bb09e9d3f93bca6a556c369efd2936
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 176570b664bb09e9d3f93bca6a556c369efd2936
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Sep 9 12:56:39 2016 +1200

Bug 1461331: Correctly classified notifications as groupmessage
behatnotneeded

Change-Id: I90976793872d761727b75fb9692425f1d1ac5eea
(cherry picked from commit b235a10ad647b566f0af29afef06670637aca564)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.