install_rally.sh missing warn () function

[John Wu]

If development library was not already installed, running ./install_rally.sh will error out due to missing warn () function:

ubuntu@test-rally:/tmp/rally$ ./install_rally.sh
The following software packages need to be installed
in order for Rally to work: build-essential libssl-dev libffi-dev python-dev libxml2-dev libxslt1-dev libpq-dev python-pip

There is a small chance that the required software
is actually installed though we failed to detect it,
so you may choose to proceed with Rally installation
anyway. Be warned however, that continuing is very
likely to fail!

Proceed with installation anyway? [yN] y
./install_rally.sh: line 368: warn: command not found <=== missing warn () function
ubuntu@test-rally:/tmp/rally$

[Albert White (albertw)]

Suggested fix:

$ git diff
diff --git a/install_rally.sh b/install_rally.sh
index d606d4c..b22dade 100755
--- a/install_rally.sh
+++ b/install_rally.sh
@@ -455,6 +455,7 @@ setup_rally_configuration () {
     rally-manage db recreate
 }

+function warn { echo "$@" >&2 ;}

 ### Main program ###
 short_opts='d:vfsyhD:p:'

$ ./install_rally.sh
Cannot determine what package manager this Linux distribution has, so I cannot check if requisite software is installed. I'm proceeding anyway, but you may run into errors later.
Destination directory '/home/aw/rally' already exists.
I can wipe it out in order to make a new installation,
but this means any files in that directory, and the ones
underneath it will be deleted.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/191874
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=6ca5af16fcaff63eb6c271fdd65f6e62a11bd1b5
Submitter: Jenkins
Branch: master

commit 6ca5af16fcaff63eb6c271fdd65f6e62a11bd1b5
Author: Chris St. Pierre <email address hidden>
Date: Mon Jun 15 11:18:56 2015 -0500

    Remove calls to non-existent 'warn' in install_rally.sh

    Replaced with 'echo'

    Closes-Bug: 1461292
    Change-Id: Ieed0da3f9b36d7ec38b854aa53a69c839744e2f7