Dell SC volume_stats could use uninitted vars

Bug #1461230 reported by Tom Swanson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Tom Swanson

Bug Description

In _update_volume_stats in dell_storagecenter_common.py totalcapacitygb and freespacegb are not necessarily initialized. Should be data['total_capacity_gb'] and data.get('free_capacity_gb').

Tags: cinder dellsc
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187736

Changed in cinder:
assignee: nobody → Tom Swanson (tom-swanson)
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/187736
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a9be9c9735a07db163e843222cae9075864e1ef0
Submitter: Jenkins
Branch: master

commit a9be9c9735a07db163e843222cae9075864e1ef0
Author: Tom Swanson <email address hidden>
Date: Tue Jun 2 14:20:55 2015 -0500

    Dell SC: update_volume_stats could use uninitialized vars

    In _update_volume_stats in dell_storagecenter_common.py totalcapacitygb
    and freespacegb are not necessarily initialized in the LOG.debug call.
    Changed to data['total_capacity_gb'] and data['free_capacity_gb'].

    Also initialized to total_capacity_gb and free_capacity_gb dict entries
    to 'unavailable' which allowed the removal of two conditionals in the
    same function.

    Change-Id: Ib699e0d1cf67645298628aa96656888193843509
    Closes-Bug: #1461230

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.