image table throws errrors into log files trying to display size attr

[Eric Peterson]

I am seeing the images table fill up our log file with messages that are completely useless / silly. There should be a getattr() with a default to None so this type of situation is more gracefully handled.

2015-06-01 20:50:11,741 32061 WARNING horizon.tables.base ^[[31;1mThe attribute size doesn't exist on <Image {u'status': u'queued', u'name': u'testImageName_27765-201502260914540762', u'deleted': False, u'container_format': u'bare', u'created_at': u'2015-02-26T16:14:56', u'disk_format': u'qcow2', u'updated_at': u'2015-02-26T16:49:14', u'id': u'58d63ece-d06c-4245-8b8b-e9236bb10470', u'owner': u'fae517f867cb4ddd867e108630f7b6fe', u'protected': False, u'min_ram': 0, u'min_disk': 0, u'is_public': False, 'properties': {}}>.^[[0m
2015-06-01 20:50:42,434 32062 WARNING horizon.tables.base ^[[31;1mThe attribute size doesn't exist on <Image {u'status': u'queued', u'name': u'testImageName_47390-201503121921360259', u'deleted': False, u'container_format': u'bare', u'created_at': u'2015-03-13T01:21:37', u'disk_format': u'qcow2', u'updated_at': u'2015-03-13T01:28:28', u'id': u'cf24fcb2-7c9f-4f49-93dc-ef1d16730a7b', u'owner': u'64a102112a124298aacd23e3afa8894e', u'protected': False, u'min_ram': 0, u'min_disk': 0, u'is_public': False, 'properties': {}}>.^[[0m
2015-06-01 20:50:42,434 32063 WARNING horizon.tables.base ^[[31;1mThe attribute size doesn't exist on <Image {u'status': u'queued', u'name': u'testImageName_27765-201502260914540762', u'deleted': False, u'container_format': u'bare', u'created_at': u'2015-02-26T16:14:56', u'disk_format': u'qcow2', u'updated_at': u'2015-02-26T16:49:14', u'id': u'58d63ece-d06c-4245-8b8b-e9236bb10470', u'owner': u'fae517f867cb4ddd867e108630f7b6fe', u'protected': False, u'min_ram': 0, u'min_disk': 0, u'is_public': False, 'properties': {}}>.^[[0m
2015-06-01 20:51:13,339 32062 WARNING horizon.tables.base ^[[31;1mThe attribute size doesn't exist on <Image {u'status': u'queued', u'name': u'testImageName_27765-201502260914540762', u'deleted': False, u'container_format': u'bare', u'created_at': u'2015-02-26T16:14:56', u'disk_format': u'qcow2', u'updated_at': u'2015-02-26T16:49:14', u'id': u'58d63ece-d06c-4245-8b8b-e9236bb10470', u'owner': u'fae517f867cb4ddd867e108630f7b6fe', u'protected': False, u'min_ram': 0, u'min_disk': 0, u'is_public': False, 'properties': {}}>.^[[0m

[Dan Siwiec (dan-siwiec)]

Is any one working on this? If not I'd be happy to pick it up.

[utsav dusad (utsavdusad)]

Go ahead Dan.

[Itxaka Serrano (itxaka)]

As Dan has not come back to pick this bug and its a very simple one I have assigned it to myself as my first openstack contribution :D

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/220835

[Itxaka Serrano (itxaka)]

https://review.openstack.org/220835

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/225427

[OpenStack Infra (hudson-openstack)]

Change abandoned by Itxaka Serrano Garcia (<email address hidden>) on branch: master
Review: https://review.openstack.org/225427
Reason: Messed up the ammend to the previous patch

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/220835
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5e4a180d4d5edb0bd00278dd5909f08986090116
Submitter: Jenkins
Branch: master

commit 5e4a180d4d5edb0bd00278dd5909f08986090116
Author: Itxaka <email address hidden>
Date: Sun Sep 6 19:53:23 2015 +0200

    Missing default value on horizon.tables Column

    There was a getattr in the Column class,
    get_raw_data method that was missing a default value,
    thus spamming the logs with warnings.
    Now it will only log if debug is enabled

    Change-Id: I8bff6670b8cb0f153d51523f9886bbcc36122a81
    Closes-Bug: #1461158
    Signed-off-by: Itxaka <email address hidden>

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 9.0.0.0rc1 release candidate.