SMBFS volume attach race condition

[Lucian Petrut]

When the SMBFS volume backend is used and a volume is detached, the according SMB share is detached if no longer used.

This can cause issues if at the same time, a different volume stored on the same share is being attached as the according disk image will not be available.

This affects the Libvirt driver as well as the Hyper-V one. In case of Hyper-V, the issue can easily be fixed by using the share path as a lock when performing attach/detach volume operations.

Trace: http://paste.openstack.org/show/256096/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/187619

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187673
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5aac3cd675af87b053e1a69d822b5f3bfdab5257
Submitter: Jenkins
Branch: master

commit 5aac3cd675af87b053e1a69d822b5f3bfdab5257
Author: Lucian Petrut <email address hidden>
Date: Tue Jun 2 18:52:23 2015 +0300

    Hyper-V: Fix SMBFS volume attach race condition

    When the SMBFS volume backend is used and a volume is detached,
    the according SMB share is unmounted if no longer used.

    This can cause issues if at the same time, a different volume
    stored on the same share is being attached as the according
    disk image will not be available.

    This patch fixes the issue by synchronizing volume attach and share
    unmount operations based on the share path.

    Closes-Bug: #1461081

    Change-Id: I45f202ad6ada0c472759e8ba3c122f3cfbeee7cc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/212483

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/212483
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=07506f55c383e01b887f6f08b265fd519e543510
Submitter: Jenkins
Branch: stable/kilo

commit 07506f55c383e01b887f6f08b265fd519e543510
Author: Lucian Petrut <email address hidden>
Date: Tue Jun 2 18:52:23 2015 +0300

    Hyper-V: Fix SMBFS volume attach race condition

    When the SMBFS volume backend is used and a volume is detached,
    the according SMB share is unmounted if no longer used.

    This can cause issues if at the same time, a different volume
    stored on the same share is being attached as the according
    disk image will not be available.

    This patch fixes the issue by synchronizing volume attach and share
    unmount operations based on the share path.

    Closes-Bug: #1461081

    Change-Id: I45f202ad6ada0c472759e8ba3c122f3cfbeee7cc
    (cherry picked from commit 5aac3cd675af87b053e1a69d822b5f3bfdab5257)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/290510

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lucian Petrut (<email address hidden>) on branch: master
Review: https://review.openstack.org/187619
Reason: This change I7b7ad794b1e15dcd63344e01a520d6c595a73d70 will fix the issue in a more generic way, helping other remote fs based volume drivers as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/383860

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/383860
Reason: This review is > 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sean Dague (<email address hidden>) on branch: master
Review: https://review.openstack.org/290510
Reason: This review is > 6 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.