Functional gate should fail on broken build link

Bug #1460959 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Critical
Martin André

Bug Description

A patch was submitted to Kolla adding a new service where the functional gate reported success while all links to the build scripts were broken due to a incomplete rebase (and things moving around in master).

The patch in question: https://review.openstack.org/#/c/182799/9

The gate log file, with the build error: http://logs.openstack.org/99/182799/9/check/check-kolla-functional-f21/4064438/console.html#_2015-06-01_17_13_46_431

The gate fail in such cases.

Martin André (mandre)
Changed in kolla:
assignee: nobody → Martin André (mandre)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/187834
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=9a5fed6608aad97ddefc31c030eb0d76c02320e5
Submitter: Jenkins
Branch: master

commit 9a5fed6608aad97ddefc31c030eb0d76c02320e5
Author: Martin André <email address hidden>
Date: Wed Jun 3 10:22:57 2015 +0900

    Fail image build when build script is missing

    When an image did not provide a build script, due to a broken link for
    instance, the build-all-docker-images script was wrongly marking the
    image as "up-to-date", and the functional gate was reporting success.

    This commit restores the expected behavior, and mark the images with
    non-existent build scripts as failures.

    Change-Id: Ifedc8d9c312925fe5aa953ed8f8fdae02b756906
    Closes-Bug: #1460959

Changed in kolla:
status: New → Fix Committed
Steven Dake (sdake)
Changed in kolla:
milestone: none → liberty-1
Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.