API for group update is not clear

Bug #1460831 reported by AJAY KALAMBUR
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Group Based Policy
Triaged
High
Sumit Naiksatam

Bug Description

The Group update API/CLI today is as below
gbp group-update web --provided-policy-rule-sets "web-ruleset=scope"

The REST API body is as follows
{"provided_policy_rule_sets": {"bf791525-c465-43d9-a999-7c4bfe459e0d": "scope"}}}'

This is confusing why am i passing a dictionary with key/value pairs. This API should be updated to make this aspect better. Currently its very confusing and misleading

Tags: ccs-seen
Changed in group-based-policy:
status: New → Confirmed
importance: Undecided → High
milestone: none → kilo-gbp-4
assignee: nobody → Sumit Naiksatam (snaiksat)
Revision history for this message
Igor D.C. (igordcard) wrote :

+1

Revision history for this message
Sumit Naiksatam (snaiksat) wrote :

This applies to create as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to group-based-policy (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209409

Changed in group-based-policy:
milestone: kilo-gbp-4 → next
Revision history for this message
Sumit Naiksatam (snaiksat) wrote :

This has been temporarily addressed in the CLI by also allowing providing only the PRS and not requiring to provide the scope:

gbp group-update web --provided-policy-rule-sets "web-ruleset"

Changed in group-based-policy:
status: Confirmed → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on group-based-policy (master)

Change abandoned by Sumit Naiksatam (<email address hidden>) on branch: master
Review: https://review.openstack.org/209409
Reason: Old patch, probably not needed, can be revived if needed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.