Mistral doesn't raise unpredictable errors

Bug #1460669 reported by Nikolay Makhotkin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Nikolay Makhotkin

Bug Description

Mistral doesn't raise unpredictable errors if error is thrown from engine via oslo.messaging to API.

When engine raises some error, oslo.messaging wraps it in messaging.rpc.client.RemoteError and transfers back to API. This transferred info contains only error class name and error text. Then we need to unwrap RemoteError and raise the real exception. A bit earlier we
assumed that all the errors should be at least MistralException (from module mistral.exceptions) but it seems engine can raise anything error, say, one of builtin exceptions - e.g. AttributeError. Need to see what error is come, check for it existing and raise it.

Mistral tries to find given wrapped error in exceptions package but it is not in it, so mistral in this case raises 'Attribute error: No such attribute <exception class>'

Changed in mistral:
milestone: liberty-1 → liberty-2
description: updated
Changed in mistral:
milestone: liberty-2 → liberty-3
Changed in mistral:
milestone: liberty-3 → none
Changed in mistral:
assignee: nobody → Nikolay Makhotkin (nmakhotkin)
milestone: none → liberty-rc1
Changed in mistral:
milestone: liberty-rc1 → rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/225587

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/225587
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=864e01b284debd189f824f8ba26e584868cca3f0
Submitter: Jenkins
Branch: master

commit 864e01b284debd189f824f8ba26e584868cca3f0
Author: Nikolay Mahotkin <email address hidden>
Date: Mon Sep 21 11:57:21 2015 +0300

    Fixing searching errors in mistral.exceptions

     * Keep the original exception and reraise

    Closes-Bug: #1460669

    Change-Id: Ieb3e55b4ceb4051e9f1c2a82b2228b34d3195bda

Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
status: Fix Committed → Fix Released
milestone: liberty-rc2 → liberty-rc1
Changed in mistral:
milestone: liberty-rc1 → liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.