image's image_topology contains non-bootable storage template against PowerVC 1.2.3

Bug #1460563 reported by Terry Yao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
powervc-driver
New
Undecided
Unassigned

Bug Description

with the latest powervc 1.2.3, the SCG's accessible storage template will contain the bootable storage template and non-bootable storage template as PowerVC added boot with boot volume and data volume support.

Currently PowerVC Driver provides an option to add a "selected-storage-template", and we told user to use glance image-show to know what's the powervc storage template is bootable:
[root@controller ibm]# glance image-show SLES11SP3
....|
| Property 'image_topology' | [{"storage_template_list": [{"id": "c4b13a8e-7571-4ee3-b914-265cb0c8340a", |
| | "name": "v7k base template"}, {"id": "cfbd4a88-c8ef-49d7-8564-aa8438222b75", |
| | "name": "dev4clstr base template"}], "display_name": "Any host in dev4clstr", |
| | "scg_id": "ec759622-3843-46e6-9a44-d712f162b34f"}] |

and like the above image_topology, we included all storage templates accessible for the SCG. But now the SCG will indicate which storage providers are boot_providers, and which storage providers are just for data volumes, we need only include the storage template in boot_providers, then such storage templates can be added into the image's image-topology' storage-template list.
{
    "storage_connectivity_groups" : [{
            "auto_add_vios" : true,
            "fc_storage_access" : true,
            "display_name" : "Any
             host in dev4clstr",
            ....
           "boot_providers" :
            ["22ba67376ed3d811e4ba520000c9d2fb5c"],
           ...
            "data_providers" : ["v7cluster1", "22ba67376ed3d811e4ba520000c9d2fb5c"]
        }
    ]
}

.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to powervc-driver (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187132

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to powervc-driver (master)

Reviewed: https://review.openstack.org/187132
Committed: https://git.openstack.org/cgit/stackforge/powervc-driver/commit/?id=a16ac6df90dbede36c942430208e67843de6352f
Submitter: Jenkins
Branch: master

commit a16ac6df90dbede36c942430208e67843de6352f
Author: terryyao <email address hidden>
Date: Mon Jun 1 16:32:46 2015 +0800

    Exclude non-bootable storage template from image-topology

    PowerVC 1.2.3 added complex boot/data volume concepts and it's image
    accessible storage connective group's volume type API will return all
    volume types for boot and data volume, we expose the PowerVC storage
    templates in image's image-topology property and that property need only
    include the bootable storage templates based on PowerVC 1.2.3 introduced
    boot/data volume concept as we just expose the volume only for boot
    volume at this time. The fix is just to exclude the SCG accessible
    storage template via it's
    ['extra_specs']['capabilities:volume_backend_name'] property, and only
    include the the storage template with such property value in SCG's
    boot_providers list which means that volume type is a bootable volume
    types. If SCG does not have such boot_providers property, then we just
    ignore such checking.

    Close-Bug: #1460563
    Change-Id: Ifa608a514ec70b831d04802b728dff14864578ab

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to powervc-driver (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/187135

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to powervc-driver (stable/kilo)

Reviewed: https://review.openstack.org/187135
Committed: https://git.openstack.org/cgit/stackforge/powervc-driver/commit/?id=b453d60e15d6c19e2c487efd54a4645d802868f5
Submitter: Jenkins
Branch: stable/kilo

commit b453d60e15d6c19e2c487efd54a4645d802868f5
Author: terryyao <email address hidden>
Date: Mon Jun 1 16:32:46 2015 +0800

    Exclude non-bootable storage template from image-topology

    PowerVC 1.2.3 added complex boot/data volume concepts and it's image
    accessible storage connective group's volume type API will return all
    volume types for boot and data volume, we expose the PowerVC storage
    templates in image's image-topology property and that property need only
    include the bootable storage templates based on PowerVC 1.2.3 introduced
    boot/data volume concept as we just expose the volume only for boot
    volume at this time. The fix is just to exclude the SCG accessible
    storage template via it's
    ['extra_specs']['capabilities:volume_backend_name'] property, and only
    include the the storage template with such property value in SCG's
    boot_providers list which means that volume type is a bootable volume
    types. If SCG does not have such boot_providers property, then we just
    ignore such checking.

    Close-Bug: #1460563
    Change-Id: Ifa608a514ec70b831d04802b728dff14864578ab
    (cherry picked from commit a16ac6df90dbede36c942430208e67843de6352f)

tags: added: in-stable-kilo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.