str2dict raise non user-friendly errors

Bug #1460336 reported by Cedric Brandily
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-neutronclient
Fix Released
Undecided
Cedric Brandily

Bug Description

str2dict(data) raises non user-friendly errors when data is not valid:

  neutron subnet-create mynetwork 10.0.0.0/23 --allocation-pools=10.0.0.0/24

     dictionary update sequence element #0 has length 1; 2 is required

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187109

Changed in python-neutronclient:
status: New → In Progress
Changed in python-neutronclient:
assignee: Cedric Brandily (cbrandily) → Kahou Lei (kahou82)
Revision history for this message
Kahou Lei (kahou82) wrote :

Hi Cedric,

I was trying to help you to fix the functional test failure by rebasing your changes. Somehow launchpad assigned the bug to me.

You can reassign the bug to you.

Sorry about that.

Changed in python-neutronclient:
assignee: Kahou Lei (kahou82) → nobody
Changed in python-neutronclient:
assignee: nobody → Cedric Brandily (cbrandily)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.openstack.org/187109
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=a2ae8ebdc30220212ba95680cfadeade848c1a7d
Submitter: Jenkins
Branch: master

commit a2ae8ebdc30220212ba95680cfadeade848c1a7d
Author: Cedric Brandily <email address hidden>
Date: Sun May 31 19:42:46 2015 +0200

    Raise user-friendly exceptions in str2dict

    Currently str2dict raises non user-friendly exceptions when input is not
    valid:

      neutron subnet-create mynetwork 10/23 --allocation-pools=10/24
      # implies str2dict('10/24')
      # raises:
         dictionary update sequence element #0 has length 1; 2 is required

    This change updates str2dict implementation in order to raise
    user-friendly exceptions.

    Closes-Bug: #1460336
    Change-Id: Id381865e6e5d9bebcb2c984c0338126566a97c2b

Changed in python-neutronclient:
status: In Progress → Fix Committed
Changed in python-neutronclient:
milestone: none → 3.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.