heat can not cleanup dead engine if updated_at is None

Bug #1459997 reported by Ethan Lynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Ethan Lynn
Kilo
Fix Released
Medium
Unassigned

Bug Description

+--------------------------+-------------+--------------------------------------+--------------------------+--------+----------------------------+--------+
| hostname | binary | engine_id | host | topic | updated_at | status |
+--------------------------+-------------+--------------------------------------+--------------------------+--------+----------------------------+--------+
| vs404.rch.kstart.ibm.com | heat-engine | 380df4e7-dbca-4390-884f-ea78fd73f6a2 | vs404.rch.kstart.ibm.com | engine | 2015-05-28T18:41:18.291954 | up |
| vs404.rch.kstart.ibm.com | heat-engine | ce38977b-9286-4ff0-a0d6-533df6f14e14 | vs404.rch.kstart.ibm.com | engine | 2015-05-28T18:41:18.401968 | up |
| vs409.rch.kstart.ibm.com | heat-engine | 2a435bb8-37ec-4db5-b4a6-2c5f27e54c99 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | 699b7b96-0af2-4086-9402-420ef59ee7dd | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | 6bbfba35-cc76-4186-964f-b2b8df6c4664 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | 734b247e-444c-497e-a3a0-da7e0b3df302 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | 98164dde-8c4b-43a4-89ca-552ab0e07bd0 | vs409.rch.kstart.ibm.com | engine | 2015-05-28T18:41:25.814769 | up |
| vs409.rch.kstart.ibm.com | heat-engine | 98f5cc65-31ee-4a13-be61-2b9b19d42d66 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | a4e6c253-da84-40cb-9c1a-eeab187fe9b1 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | b102ad38-5212-4354-89ca-6742aff55b70 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs409.rch.kstart.ibm.com | heat-engine | d3106854-3c7b-41a5-b1e3-2f9e0b98bca5 | vs409.rch.kstart.ibm.com | engine | 2015-05-28T18:41:25.748637 | up |
| vs409.rch.kstart.ibm.com | heat-engine | f6158f12-6b10-43e2-8d64-a913da8a2317 | vs409.rch.kstart.ibm.com | engine | None | down |
| vs425.rch.kstart.ibm.com | heat-engine | 629cc27a-8641-405b-932c-25bdc7f5342c | vs425.rch.kstart.ibm.com | engine | 2015-05-28T18:41:20.690532 | up |
| vs425.rch.kstart.ibm.com | heat-engine | 65efc561-70e1-458a-8fb3-8ac74088844a | vs425.rch.kstart.ibm.com | engine | 2015-05-28T18:41:20.817643 | up |
+--------------------------+-------------+--------------------------------------+--------------------------+--------+----------------------------+--

If updated_at column is None, then this dead engine can not be remove from service-list.

Ethan Lynn (ethanlynn)
Changed in heat:
assignee: nobody → Ethan Lynn (ethanlynn)
tags: added: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/187043

Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/187043
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4b9c2caf3b7b44a66b472acae8198c188acba377
Submitter: Jenkins
Branch: master

commit 4b9c2caf3b7b44a66b472acae8198c188acba377
Author: Ethan Lynn <email address hidden>
Date: Sun May 31 18:45:46 2015 +0800

    Report status when engine start

    After heat engine starts, it won't report its status, so
    updated_at is None by then. If heat engine die before its first
    status report, its record will not remove from service-list.

    Change-Id: I55801ceb12ec8e4a3746799d3d43c6e9c01c6cd8
    Closes-Bug: #1459997

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/187104

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/187104
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=be9af2811ce72c55da322f240364e99e02cd5471
Submitter: Jenkins
Branch: stable/kilo

commit be9af2811ce72c55da322f240364e99e02cd5471
Author: Ethan Lynn <email address hidden>
Date: Sun May 31 18:45:46 2015 +0800

    Report status when engine start

    After heat engine starts, it won't report its status, so
    updated_at is None by then. If heat engine die before its first
    status report, its record will not remove from service-list.

    Change-Id: I55801ceb12ec8e4a3746799d3d43c6e9c01c6cd8
    Closes-Bug: #1459997
    (cherry picked from commit 4b9c2caf3b7b44a66b472acae8198c188acba377)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in heat:
milestone: none → liberty-1
status: Fix Committed → Fix Released
tags: removed: kilo-backport-potential
Changed in heat:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.