Add request ID to worker-side logs

Bug #1459800 reported by Douglas Mendizábal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Wishlist
Elvin Tubillara

Bug Description

Add Request ID to logs in barbican. This can help correlate errors in logs to an incoming request.

Revision history for this message
John Wood (john-wood-w) wrote :

It would also be good to add the request ID to the RPC arguments passed to the worker/queue processes. Then the worker side logs could be similarly logged with the request ID to help filter logs for a given request.

Revision history for this message
John Wood (john-wood-w) wrote :

So the change sequence needed here would be:

1) Update barbican/queue's server.py and client.py modules to add a new add a new 'request_id' keyword arg to all client calls

2) Update the API controller calls that send RPC tasks to the queue, to populate the 'request_id' keyword arg

3) On the server side (so the worker side), set this 'request_id' on the logging context once an RPC task is invoked

summary: - Add request ID to logs
+ Add request ID to worker-side logs
Changed in barbican:
assignee: nobody → Elvin Tubillara (edtubill)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217775

Changed in barbican:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/217775
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=d6394a2a27a6e793709ac79535e362a18bce249c
Submitter: Jenkins
Branch: master

commit d6394a2a27a6e793709ac79535e362a18bce249c
Author: Elvin Tubillara <email address hidden>
Date: Thu Aug 27 10:43:52 2015 -0500

    Add Request ID to worker-side logs in barbican.

    This can help correlate errors in logs to an incoming request
    The request ID is additionally added to the RPC task args that is put into
    the queue by the server. The client worker then includes the request ID
    in the logs when it performs the task.

    Change-Id: Ic359228cd7877022530be21c7d00996d5723a8e0
    Closes-bug: #1459800

Changed in barbican:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in barbican:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: liberty-3 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.