method signatures in db/sqlalchemy/api.py does not match its base method
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Magnum |
Fix Released
|
High
|
Unassigned |
Bug Description
I found in db/sqlalchemy/
```
def get_bay_list(self, context, filters=None, limit=None, marker=None,
```
It missed `columns=None` from the base method signature at https:/
```
def get_bay_list(self, context, columns=None, filters=None, limit=None,
```
Other occurrences including
https:/
https:/
https:/
https:/
https:/
https:/
Another problem is https:/
Changed in magnum: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in magnum: | |
milestone: | none → mitaka-2 |
status: | Fix Committed → Fix Released |
Changed in magnum: | |
milestone: | mitaka-2 → mitaka-1 |
Reviewed: https:/ /review. openstack. org/186387 /git.openstack. org/cgit/ openstack/ magnum/ commit/ ?id=fd34adb8e7e 0134363bc467306 dc1952946e3f4c
Committed: https:/
Submitter: Jenkins
Branch: master
commit fd34adb8e7e0134 363bc467306dc19 52946e3f4c
Author: Accela Zhao <email address hidden>
Date: Mon Jun 1 18:56:09 2015 -0700
Fix method signatures unmatching in db api
There are a few method signatures in db/api.py who unmatches their
children. For example `get_bay_list`
```
marker= None, sort_key=None, sort_dir=None):
def get_bay_list(self, context, columns=None, filters=None, limit=None,
```
The argument `columns` is never being respected or used in children or
elsewhere. After collecting a few opinions we decided to remove the unused
argument `column` from the base methods in db/api.py.
Besides, there is another unmatch in db/api.py
``` by_name( self, bay_name):
def get_service_
```
It misses argument `context` compared to its only child in sqlalchemy/ api.py. This patch adds the argument `context`.
db/
Closes-Bug: #1459662 2d6bbe4539b3c59 4fb45744874
Change-Id: If4f60661c9cd18