API "update security service" verifies "show" policy instead of "update" policy

Bug #1459631 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
Valeriy Ponomaryov

Bug Description

See: https://github.com/openstack/manila/blob/a2682481/manila/api/v1/security_service.py#L171

Manila API for update of security service reads policy for "show" operation but should do it for "update" operation.

Tags: api
Changed in manila:
milestone: none → liberty-1
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
tags: added: api
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/186460

Changed in manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/186460
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=df6ca7ee5f89e69ff51bcebdfbd1fe9a2699625c
Submitter: Jenkins
Branch: master

commit df6ca7ee5f89e69ff51bcebdfbd1fe9a2699625c
Author: Valeriy Ponomaryov <email address hidden>
Date: Thu May 28 19:20:35 2015 +0300

    Fix policy check for API 'security service update'

    Manila API for update of security service reads policy for "show" operation
    but should do it for "update" operation.

    Change-Id: I675f834fcb75f3b7864094601e47c15f60a0864b
    Closes-Bug: #1459631

Changed in manila:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in manila:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.