[Backport 1311533 / 1298350] Heat is unable to attach/detach volumes

[Denis Meltsaykin]

This is a backport of https://bugs.launchpad.net/heat/+bug/1311533 and https://bugs.launchpad.net/heat/+bug/1298350
Original descriptions:
--------------------------------------------------------------------------------------------------------------------
 volume device doesn't comes up in nova instance provisioned with heat.
--------------------------------------------------------------------------------------------------------------------
Heat is unable to detach volumes from servers
Steps to reproduce:
1) Create stack with 2 servers and 2 volumes attached per instance;
     The template could be is as follows: http://paste.openstack.org/show/74431/

2) After stack moved to CREATE_COMPLETE try to delete this stack;

Expected result:
Stack has been completely removed and all provisioned resources removed as well

Actual behaviour:
Stack is on DELETE_IN_PROGRESS or DELETE_FAILED state and some of volumes and instances are not removed.

Note:
To increase reproducibility you can increase number of servers OR/AND volumes per instances as well.
---------------------------------------------------------------------------------------------------------------------

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Change author: Sushil Kumar <email address hidden>
Review: https://review.fuel-infra.org/7136

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-5.1.2/2014.1.1
Change author: Sushil Kumar <email address hidden>
Review: https://review.fuel-infra.org/7137

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7136
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-5.1.1-updates/2014.1.1

Commit: a247564f14d4cae6cb141d67104242ff53f304ef
Author: Sushil Kumar <email address hidden>
Date: Thu May 28 10:12:38 2015

Call server volume detach only once

Changes:
 - Removed duplicate delete calls to prevent race condition.
 - Removed duplicate mocked calls from unit-test.

Closes-Bug: #1459605

Conflicts:
 heat/engine/resources/volume.py
 heat/tests/test_volume.py

Change-Id: I5f16c528652f12440160f03b92f41b76d1c9100c
(cherry picked from commit d1ffbd4bfde0cd6b7a82a48b9d4f59cc8b310bd8)

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7133
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-5.1-updates/2014.1.1

Commit: 9fb1c578a07e1e1bf930e13459b17b6776dcd1cc
Author: Sushil Kumar <email address hidden>
Date: Thu May 28 10:10:05 2015

Call server volume detach only once

Changes:
 - Removed duplicate delete calls to prevent race condition.
 - Removed duplicate mocked calls from unit-test.

Closes-Bug: #1459605

Conflicts:
 heat/engine/resources/volume.py
 heat/tests/test_volume.py

Change-Id: I5f16c528652f12440160f03b92f41b76d1c9100c
(cherry picked from commit d1ffbd4bfde0cd6b7a82a48b9d4f59cc8b310bd8)

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7137
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-5.1.2/2014.1.1

Commit: c9ef488917233d3ce468960518429cbbb64c7d7f
Author: Sushil Kumar <email address hidden>
Date: Thu May 28 10:14:28 2015

Call server volume detach only once

Changes:
 - Removed duplicate delete calls to prevent race condition.
 - Removed duplicate mocked calls from unit-test.

Closes-Bug: #1459605

Conflicts:
 heat/engine/resources/volume.py
 heat/tests/test_volume.py

Change-Id: I5f16c528652f12440160f03b92f41b76d1c9100c
(cherry picked from commit d1ffbd4bfde0cd6b7a82a48b9d4f59cc8b310bd8)

[Denis Meltsaykin (dmeltsaykin)]

This bug is not relevant for any other release but 5.1, so closing other milestones as Invalid.